fix(issues): Balance stack trace frame headers#119792
Conversation
Long filenames could crowd out function names, while long package names competed equally with the more useful function context. Cap filenames only on collapsed frames with functions, let package context yield first, and tighten the action spacing. Expanded and package-only frames keep the full available width. Co-Authored-By: OpenAI Codex <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-5sm87c82u.sentry.dev |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5b99135. Configure here.
| gap: ${p => p.theme.space.sm}; | ||
| min-width: 0; | ||
| overflow: hidden; | ||
| `; |
There was a problem hiding this comment.
New styled flex wrappers
Low Severity
FunctionContext and PackageContext are new styled() wrappers that set display: inline-flex. Frontend guidelines require layout via Flex from @sentry/scraps/layout instead of hand-rolled flex styled components. Flex already supports as="span", display="inline-flex", align, flex, gap, minWidth, and overflow.
Additional Locations (1)
Triggered by project rule: Frontend guidelines
Reviewed by Cursor Bugbot for commit 5b99135. Configure here.
| align-items: baseline; | ||
| min-width: 0; | ||
| max-width: 100%; | ||
| max-width: ${p => (!p.isExpanded && p.hasFunction ? '55%' : '100%')}; |
There was a problem hiding this comment.
Lead hint reduces path budget
Low Severity
The new 55% collapsed cap is applied on LocationWrapper, which also wraps the non-shrinking LeadHint. On lead-hint frames, hint text such as Crashed in non-app consumes part of that budget, so the path truncates more than the intended filename-vs-function balance.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 5b99135. Configure here.
2 participants
Long filenames in collapsed stack trace frames could take over the header and hide most of the function name. Long package names also competed equally with the more useful function context.
Give filenames a balanced cap only when a collapsed frame has a function, let package context yield first, and tighten the action spacing. Expanded and package-only frames keep the full available width.
before
after