fix(action log): Set date_updated to current datetime#119791
Open
ceorourke wants to merge 3 commits into
Open
Conversation
github-actions
Bot
added
the
Scope: Backend
kcons
approved these changes
Jul 15, 2026
| json.dumps(entry.action.dict()), | ||
| entry.date_added, | ||
| entry.date_added, # date_updated | ||
| timezone.now(), # date_updated |
Member
There was a problem hiding this comment.
This is an improvement, but I think the ideal would be that the insert function did this for us. Two paths to that I see:
- tell postgres to use NOW() as the default, just remove this from our insert.
- Just insert the timezone.now() in the helper.. which is weird, so I'd kinda favor taking a dataclass with named fields or a namedtuple over a list of various types, as that'd make safely removing a thing and defaulting it interally easier.
ceorourke
force-pushed
the
ceorourke/ISWF-3026
branch
from
9cdbb5d to
e9273d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
date_updatedto current date time inGroupActionLogEntrybackfill task instead of the activity's date added.