fix(search): Preserve negation on quoted colon-value filters#119789
Merged
Conversation
The MutableSearch colon-value special case (which strips quotes from values like user:"id:123" -> user:id:123) rebuilt the token text from the key, operator, and value but omitted the negation. For text filters the leading "!" is stored in the separate negated field, so it was silently dropped. This surfaced on the Issue Details page, which normalizes the query through MutableSearch: a negated filter such as !message:"gpu::" flipped to the positive message:gpu::, inverting the filter and returning almost no events. Re-add the negation prefix when rebuilding the text, and guard it with a regression test. Fixes GH-119703 Refs ID-1705 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
cvxluo
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MutableSearch colon-value special case (which strips quotes from values like user:"id:123" -> user:id:123) rebuilt the token text from the key, operator, and value but omitted the negation. For text filters the leading "!" is stored in the separate negated field, so it was silently dropped.
This surfaced on the Issue Details page, which normalizes the query through MutableSearch: a negated filter such as !message:"gpu::" flipped to the positive message:gpu::, inverting the filter and returning almost no events.
Re-add the negation prefix when rebuilding the text, and guard it with a regression test.
Fixes GH-119703
Refs ID-1705