Skip to content

ref(eap): make trace item attributes alias test less fragile#116545

Merged
mjq merged 1 commit into
masterfrom
mjq/less-fragile-op-test
Jun 1, 2026
Merged

ref(eap): make trace item attributes alias test less fragile#116545
mjq merged 1 commit into
masterfrom
mjq/less-fragile-op-test

Conversation

@mjq
Copy link
Copy Markdown
Member

@mjq mjq commented May 30, 2026

OrganizationTraceItemAttributesEndpointSpansTest::test_aliased_attribute in tests/snuba/api/endpoints/test_organization_trace_item_attributes.py revealed itself to be fragile in #116509, when adding new attributes suddenly broke its assertions around op aliases:

# These two are unrelated, but happen to match.
assert "db.operation" in keys
assert "db.operation.name" in keys

Update the test to be less fragile, focusing on the presence or absence of op aliases rather than complete keys results.

@mjq mjq marked this pull request as ready for review May 30, 2026 00:28
@mjq mjq requested a review from a team as a code owner May 30, 2026 00:28
@mjq mjq merged commit 7845350 into master Jun 1, 2026
53 of 55 checks passed
@mjq mjq deleted the mjq/less-fragile-op-test branch June 1, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants