fix(eap): Handle None exception data in event forwarding#116544
Open
roggenkemper wants to merge 2 commits into
Open
fix(eap): Handle None exception data in event forwarding#116544roggenkemper wants to merge 2 commits into
roggenkemper wants to merge 2 commits into
Conversation
When relay normalizes malformed exception data, it sets the field to
None rather than removing the key. `.get("exception", {})` only uses
the default when the key is missing, so None.get("values") throws
AttributeError.
Fixes SENTRY-S4S2#21663
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
followup to #116511. Handle the case where relay normalizes malformed exception data by setting
the
exceptionfield toNonerather than removing the key entirely..get("exception", {})only uses the default when the key is missing — whenit exists with a
Nonevalue, the subsequent.get("values", [])call throwsAttributeError: 'NoneType' object has no attribute 'get'. Using(event_data.get("exception") or {})handles both cases. Also filters outNoneentries in the values list.