chore(repositories): When making a ProjectRepository link, upgrade the source if we have a stronger signal#116543
Open
wedamija wants to merge 2 commits into
Open
chore(repositories): When making a ProjectRepository link, upgrade the source if we have a stronger signal#116543wedamija wants to merge 2 commits into
wedamija wants to merge 2 commits into
Conversation
…e source if we have a stronger signal We're adding auto detection of links in #116533 and potentially in other places. If we get a stronger signal that the link is correct later we should update the row.
github-actions
Bot
added
the
Scope: Backend
…notation Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 202ffbb. Configure here.
srest2021
approved these changes
Jun 1, 2026
Member
srest2021
left a comment
srest2021
left a comment
There was a problem hiding this comment.
Lgtm, couple minor optional nits
| source=ProjectRepositorySource.SCM_ONBOARDING, | ||
| ) | ||
| assert not created | ||
| assert pr.source == ProjectRepositorySource.MANUAL |
| self, | ||
| project_id: int, | ||
| repository_id: int, | ||
| source: int, |
Member
There was a problem hiding this comment.
can be typed ProjectRepositorySource
| and source != ProjectRepositorySource.AUTO_NAME_MATCH | ||
| ): | ||
| project_repo.source = source | ||
| project_repo.save(update_fields=["source"]) |
Member
There was a problem hiding this comment.
Could be nice to have an array like
# Indicates how 'strong of a signal' each source is. A lower number indicates
# less confdence that the linking is correct.
SOURCE_PRIORITY: dict[ProjectRepositorySource, int] = {
MANUAL = 500
SEE_PREFERENCE = 500
AUTO_EVENT = 200
AUTO_NAME_MATCH = 100
}then we could compare current and new source to decide if we're upgrading.
evanpurkhiser
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're adding auto detection of links in #116533 and potentially in other places. If we get a stronger signal that the link is correct later we should update the row.