fix: Trigger ad-hoc explorer index runs#116530
Open
shruthilayaj wants to merge 3 commits into
Open
Conversation
The index trigger dispatches Celery tasks that, in test environments with CELERY_ALWAYS_EAGER, run synchronously and query the control DB while the outbox drain transaction on the region DB is still open. This causes CrossTransactionAssertionError in hybrid-cloud silo tests. Wrap the trigger in transaction.on_commit so it fires after the outbox transaction commits, matching the semantic intent (only trigger if processing succeeded) and avoiding the cross-DB transaction violation. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
Mihir-Mavalankar
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
organizations:seer-run-mirror-exploreron SeerAgentClient.start_run meantwe weren't triggering the ad-hoc create explorer index tasks. This PR now calls the
index build tasks for explorer runs.
compute_delaywas causing a circular import - so just moved that to a utils file