fix(project transfer): Clone shared workflows when transferring project#116522
Open
ceorourke wants to merge 3 commits into
Open
fix(project transfer): Clone shared workflows when transferring project#116522ceorourke wants to merge 3 commits into
ceorourke wants to merge 3 commits into
Conversation
github-actions
Bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a project is transferred to a new organization we move over all of the
RuleandAlertRuleobjects but don't necessarily move over all theWorkflowobjects. Workflows can be connected to multiple detectors that could be in multiple projects, and if that is the case, we don't transfer them. This leaves us in an inconsistent state because we've dual written most (except for recently created ones) workflows with a rule or alert rule and we've ended up withAlertRuleWorkflowrows that reference 2 organizations. When we use that model to look something up, we could end up fetching data from the wrong organization. Previous PRs have added checks against that, but this fixes the project transfer to deeply clone the Workflow if it is shared so that it can live in both organizations and avoid this problem.