fix(trace-waterfall): Fix collapsed transaction indentation in trace waterfall#112912
Open
nsdeschenes wants to merge 3 commits intomasterfrom
Open
fix(trace-waterfall): Fix collapsed transaction indentation in trace waterfall#112912nsdeschenes wants to merge 3 commits intomasterfrom
nsdeschenes wants to merge 3 commits intomasterfrom
Conversation
Compute row depth and connectors from the visible tree when collapsed EAP transactions surface nested descendants. This keeps summarized child transactions aligned under the collapsed transaction instead of inheriting indentation from hidden span parents. Co-Authored-By: Codex <noreply@openai.com>
Add assertions for the visible parent and depth of nested EAP transactions when their ancestor transaction is collapsed, and update the rendered tree snapshots to match the corrected indentation. Co-Authored-By: Codex <noreply@openai.com>
Treat the synthetic trace root row as the last visible child when visible-parent lookup falls back to null. This preserves the collapsed-row indentation fix without adding an extra connector to the trace header. Co-Authored-By: Codex <noreply@openai.com>
github-actions
bot
added
the
Scope: Frontend
Contributor
Sentry Snapshot Testing
|
nsdeschenes
changed the title
Contributor
Author
|
@cursor review |
Contributor
Author
|
@sentry review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b6f8cc8. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing an indentation and connector rendering issue for collapsed EAP transactions.
When a collapsed EAP transaction surfaces nested descendant transactions, the waterfall was still using their structural parents to compute depth and connectors. That pushed rows too far to the right even though they were being rendered as direct visible children. This change computes depth and connector state from the visible tree instead.