feat(np): Adds renderer for MSTeams issue alerts#112890
Draft
GabeVillalobos wants to merge 1 commit intomasterfrom
Draft
feat(np): Adds renderer for MSTeams issue alerts#112890GabeVillalobos wants to merge 1 commit intomasterfrom
GabeVillalobos wants to merge 1 commit intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
| return MSTeamsMessageBuilder().build( | ||
| title=cls.build_title(group=group, issue_url=issue_url), | ||
| fields=fields, | ||
| actions=cls.build_actions(issue_url=issue_url), |
Contributor
There was a problem hiding this comment.
build_actions called without required group parameter causes TypeError
On line 89, cls.build_actions(issue_url=issue_url) is called but the method signature on line 159 requires both group: Group and issue_url: str parameters. This will raise TypeError: build_actions() missing 1 required keyword-only argument: 'group' when rendering any MSTeams issue notification. The group variable is available in scope and should be passed.
Verification
Read the full file to confirm the method signature at line 159 is def build_actions(cls, *, group: Group, issue_url: str) -> list[Action] and the call at line 89 only passes issue_url=issue_url. The group parameter is required (keyword-only after *) but not provided.
Suggested fix: Pass the group parameter to build_actions
Suggested change
| actions=cls.build_actions(issue_url=issue_url), | |
| actions=cls.build_actions(group=group, issue_url=issue_url), |
Identified by Warden sentry-backend-bugs · 259-7AC
Comment on lines
161
to
162
| event_data = invocation.event_data | ||
|
|
Contributor
There was a problem hiding this comment.
Dead code: Registry.get() never returns None, so ValueError is never raised
In issue_notification_data_factory, the code checks if handler is None after calling issue_alert_handler_registry.get(action.type). However, Registry.get() raises NoRegistrationExistsError when the key is not found - it never returns None. This means the ValueError with the custom error message is dead code and will never execute. If an unsupported action type is passed, callers receive NoRegistrationExistsError instead of the intended ValueError.
Verification
Read sentry/utils/registry.py lines 45-48 confirming Registry.get() raises NoRegistrationExistsError on missing keys. The None check at line 161-162 is unreachable.
Identified by Warden sentry-backend-bugs · DTW-E3M
Contributor
Backend Test FailuresFailures on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.