ref(cells): Safe Python symbol renames in relocation module#112884
Open
ref(cells): Safe Python symbol renames in relocation module#112884
Conversation
Rename Python-level symbols (class names, variable names, parameters, comments, docstrings) from "region" to "cell" terminology in the relocation export service, transfer tasks, and related tests. Wire format strings, DB column names, Celery task name= strings, and Django model names are intentionally left unchanged for a later migration.
github-actions
bot
added
the
Scope: Backend
markstory
approved these changes
Apr 14, 2026
| retry=Retry(times=MAX_FAST_TASK_RETRIES, on=(Exception,), times_exceeded=LastAction.Discard), | ||
| ) | ||
| def uploading_start(uuid: str, replying_region_name: str | None, org_slug: str | None) -> None: | ||
| def uploading_start(uuid: str, replying_cell_name: str | None, org_slug: str | None) -> None: |
Member
There was a problem hiding this comment.
All the callers are using delay() without parameter names so this will be safe at deploy time.
Comment on lines
318
to
+321
| def fulfill_cross_region_export_request( | ||
| uuid_str: str, | ||
| requesting_region_name: str, | ||
| replying_region_name: str, | ||
| requesting_cell_name: str, | ||
| replying_cell_name: str, |
Member
There was a problem hiding this comment.
All callers use positional args 👍
Comment on lines
+341
to
+342
| "requesting_region_name": requesting_cell_name, | ||
| "replying_region_name": replying_cell_name, |
Member
There was a problem hiding this comment.
If you wanted to rename the keys here you could. There aren't any dashboards attached to this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename Python-level symbols (class names, variable names, parameters, comments, docstrings) from "region" to "cell" terminology in the relocation export service, transfer tasks, and related tests.
Wire format strings, DB column names, Celery task name= strings, logged messages and tags, and Django model names are intentionally left unchanged for a later migration.