feat(cells): Compare locality not cell name in fork locality restriction#112883
Open
feat(cells): Compare locality not cell name in fork locality restriction#112883
Conversation
CANNOT_FORK_FROM_REGION contained locality names (e.g. "de") but was compared against cell names. This works now while cells and localities are 1:1 named, but will break as a locality grows to contain multiple cells (e.g. "us1", "us2"). Now we resolve the replying cell name to its locality via get_global_directory().get_locality_for_cell() before comparing, with a fallback to the cell name for test environments without locality config. Rename CANNOT_FORK_FROM_REGION -> CANNOT_FORK_FROM_LOCALITY and the error constant accordingly.
github-actions
bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CANNOT_FORK_FROM_REGION contained locality names (e.g. "de") but was compared against cell names. This works now while cells and localities are 1:1 named, but will not work in the future when we allow localities to grow to contain multiple cells (e.g. "us1", "us2" cells in "us" locality).
Now we resolve the replying cell name to its locality via
get_global_directory().get_locality_for_cell()before comparing, with a fallback to the cell name for test environments without locality config. Rename CANNOT_FORK_FROM_REGION -> CANNOT_FORK_FROM_LOCALITY and the error constant accordingly.