fix(dashboards): Skip dashboard API requests when user has no project access#112855
Open
edwardgou-sentry wants to merge 1 commit intomasterfrom
Open
Conversation
… access Extract a reusable `useHasProjectAccess` hook from `NoProjectMessage` and use it to disable dashboard queries (`useApiQuery`, `useOwnedDashboards`, `useGetStarredDashboards`) when the user has no accessible projects. Previously these requests fired unconditionally even though `NoProjectMessage` would discard the rendered results. DAIN-1416
github-actions
bot
added
the
Scope: Frontend
gggritso
approved these changes
Apr 14, 2026
Member
gggritso
left a comment
gggritso
left a comment
There was a problem hiding this comment.
👍🏻 Might be a bit cleaner if the hook just returns a single boolean that determines whether the UI can be shown or not, but not a big deal. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useHasProjectAccesshook fromNoProjectMessageto consolidate the project access check logicNoProjectMessagewould discard the rendered resultsDAIN-1416