test(acceptance): Remove unused visual snapshot tests#109429
Open
test(acceptance): Remove unused visual snapshot tests#109429
Conversation
Remove 22 test files that were written for visual snapshot comparison, which is no longer used in Sentry. These tests had zero behavioral assertions—they only navigated to a page and waited for loading indicators to disappear, providing no real value for regression detection. Also remove two orphaned page object fixtures (dashboard_detail.py, transaction_summary.py) that were only used by deleted tests. From test_organization_releases.py, keep test_detail_pick_project which has a real assertion; remove test_list, test_detail, and test_detail_with_discover_and_performance. From test_performance_issues.py, keep tests with Group.objects.count() assertions; remove test_with_one_performance_issue and test_n_one_api_call_performance_issue which were navigate-only. Deleted files account for ~2,088 lines removed across acceptance tests and fixtures.
joshuarli
approved these changes
Feb 26, 2026
ryan953
approved these changes
Feb 26, 2026
JoshFerge
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove 22 test files that were written for visual snapshot comparison, which Sentry no longer uses. These tests had zero behavioral assertions—they only navigated to a page and waited for loading indicators to disappear, providing minimal value for regression detection.
Also delete two orphaned page object fixtures (dashboard_detail.py, transaction_summary.py) that were only used by the removed tests.
From mixed files, keep tests with real assertions:
assert); remove test_list and others~2,088 lines removed across 26 files total.