fix(metric-issue): Defer chart request until open period has loaded#109425
Merged
fix(metric-issue): Defer chart request until open period has loaded#109425
Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable autofix in the Cursor dashboard.
| }); | ||
|
|
||
| if (isLoading) { | ||
| if (isOpenPeriodPending || isLoading) { |
Contributor
There was a problem hiding this comment.
Chart can stall without selected event
Medium Severity
useEventOpenPeriod is now gated through isOpenPeriodPending, and useMetricDetectorChart is disabled while pending. When event is undefined, useEventOpenPeriod is created with enabled: false, which leaves React Query in a pending state, so isOpenPeriodPending || isLoading keeps metricIssueChart.tsx in the placeholder indefinitely.
Member
There was a problem hiding this comment.
this does sound somewhat legit, but i think we're waiting anyway?
scttcper
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The open period, when it loads, may (and most often does) change the selected time range. To avoid the chart loading twice, this waits for the open period to be loaded before firing the request.