ref(models): Pending-delete CodeReviewEvent table [1/3]#109420
Merged
Conversation
Remove the CodeReviewEvent model class and mark the table for pending deletion. The table has no data and will be recreated with an updated schema (DefaultFieldsModel, FlexibleForeignKey, Organization relocation scope) per reviewer feedback on PR #108531. The CodeReviewEventStatus enum is kept since migration 1032 references it for the status field default. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Backend
Co-Authored-By: Claude <noreply@anthropic.com>
wedamija
approved these changes
Feb 26, 2026
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Moved model CodeReviewEvent to pending deletion state
--
-- (no-op) |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
The SafeDeleteModel DELETE migration needs to resolve the database for the sentry_code_review_event table after the model class is removed. Without this entry, the migration cannot determine the correct silo. Co-Authored-By: Claude <noreply@anthropic.com>
vaind
added a commit
that referenced
this pull request
Feb 27, 2026
Drop the `sentry_code_review_event` table. This is the second step of the safe deletion process. **Stacked on #109420** (pending delete). Retarget to `master` after PR 1 merges. **This is PR 2 of 3:** 1. #109420 — `SafeDeleteModel` with `MOVE_TO_PENDING` (removes model from Django state) 2. **This PR** — `SafeDeleteModel` with `DELETE` (drops the table) 3. Recreate the model with updated schema Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
CodeReviewEventmodel class and mark the table for pending deletion. The table has no data and will be recreated with an updated schema per reviewer feedback on PR #108531.This is PR 1 of 3:
SafeDeleteModelwithMOVE_TO_PENDING(removes model from Django state, keeps table in DB)SafeDeleteModelwithDELETE(drops the table)DefaultFieldsModel,FlexibleForeignKeyfor org/repo,RelocationScope.OrganizationThe
CodeReviewEventStatusenum is kept in the file since migration 1032 references it for thestatusfield default.