ref(dataforwarding) split into separate forms#109392
ref(dataforwarding) split into separate forms#109392JonasBa wants to merge 3 commits intojb/settings/data-forwarding-formfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
…-forwarding-form-consolidation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| queue_url: z.string().min(1, t('Queue URL is required')), | ||
| region: z.string().min(1, t('Region is required')), | ||
| access_key: z.string().min(1, t('Access key is required')), | ||
| secret_key: z.string().min(1, t('Secret key is required')), |
There was a problem hiding this comment.
Validation no longer rejects whitespace-only input values
Low Severity
The old validation used !data.field?.trim() via superRefine, which rejected both empty and whitespace-only strings. The new schemas use z.string().min(1), which only checks length — a whitespace-only value like " " has length > 0 and passes validation. This weakens client-side validation for all required provider config fields (queue_url, region, access_key, secret_key, write_key, instance_url, token, index, source). Using z.string().trim().min(1) would restore the original behavior.
Additional Locations (2)
|
@TkDodo this is the final PR in the stack of data-forwarding form changes 🙏🏼 |
1 participant
This PR splits the data forwarded forms into separate schemas, using useFieldGroup to manage form configuration between the otherwise duplicate fields