Skip to content

chore(publish): Fix release.yml commit patterns#1185

Merged
Lms24 merged 1 commit into
masterfrom
lms/chore-fix-release.yaml
Jan 9, 2026
Merged

chore(publish): Fix release.yml commit patterns#1185
Lms24 merged 1 commit into
masterfrom
lms/chore-fix-release.yaml

Conversation

@Lms24
Copy link
Copy Markdown
Member

@Lms24 Lms24 commented Jan 9, 2026

The regexp patterns in release.yml were incorrect and craft couldn't parse them. This made it choose its default changelog template over our customized version. This PR fixes the patterns, by mostly following the defaults from craft.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 9, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

@Lms24 Lms24 self-assigned this Jan 9, 2026
@Lms24 Lms24 requested review from BYK and andreiborza January 9, 2026 10:03
@Lms24 Lms24 added the skip-changelog If set, this PR will not be mentioned in the changelog once the PR is merged and published label Jan 9, 2026
@Lms24 Lms24 merged commit 3687ef3 into master Jan 9, 2026
55 checks passed
@Lms24 Lms24 deleted the lms/chore-fix-release.yaml branch January 9, 2026 16:03
@BYK
Copy link
Copy Markdown
Member

BYK commented Jan 9, 2026

@Lms24 the only change seems to be the title "Internal Changes", right? I can pull that into the default template so you don't have to override.

Copy link
Copy Markdown
Member Author

Lms24 commented Jan 12, 2026

The primary intent for the custom config was

  • internal changes
  • removing the AI-esque emojis from the main sections 😅

No strong feelings about this being default or not. Whatever you think makes more sense for craft 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog If set, this PR will not be mentioned in the changelog once the PR is merged and published

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants