chore(hub): Deprecate Hub::with#1126
Merged
Merged
Conversation
szokeasaurusrex
commented
May 8, 2026
lcian
approved these changes
May 11, 2026
Member
lcian
left a comment
lcian
left a comment
There was a problem hiding this comment.
So, to the user we always give out an Arc::clone, and internally we use the direct with_borrow path which may panic, which we're making sure to use safely.
LGTM
szokeasaurusrex
force-pushed
the
szokeasaurusrex/deprecate-hub-with
branch
from
3a1defa to
4573da4
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/thread-hub-simplification
branch
from
752cbbc to
87d0c23
Compare
Base automatically changed from
szokeasaurusrex/thread-hub-simplification
to
master
May 26, 2026 13:13
Following the safety improvements in #1123, `Hub::with` no longer offers any performance benefit over using `Hub::current`. `Hub::current` provides a simpler API, and also returns an owned `Arc<Hub>` rather than providing access to a `&Arc<Hub>` via a callback (necessitating a second clone for anyone needing an owned `Arc<Hub>` in that callback). As `Hub::current` is the arguably better API, let's deprecate `Hub::with` and encourage folks to migrate.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/deprecate-hub-with
branch
from
4573da4 to
b54079c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the safety improvements in #1123,
Hub::withno longer offers any performance benefit over usingHub::current.Hub::currentprovides a simpler API, and also returns an ownedArc<Hub>rather than providing access to a&Arc<Hub>via a callback (necessitating a second clone for anyone needing an ownedArc<Hub>in that callback).As
Hub::currentis the arguably better API, let's deprecateHub::withand encourage folks to migrate.Stacked on #1125