Skip to content

Conversation

@saviogl
Copy link
Contributor

@saviogl saviogl commented Aug 25, 2025

Adds parsing logic for OTel spans with messaging.system attributes to properly categorize queue operations. Producer spans get 'queue.publish' operation and consumer spans get 'queue.process' operation. The span description is extracted from the span name (e.g., "Sidekiq::Worker" from "Sidekiq::Worker publish").

Thanks for your Pull Request 🎉

Please keep these instructions in mind so we can review it more efficiently:

  • Add the references of all the related issues/PRs in the description
  • Whether it's a new feature or a bug fix, make sure they're covered by new test cases
  • If this PR contains any refactoring work, please give it its own commit(s)
  • Finally, please add an entry to the corresponding changelog

Other Notes

  • We squash all commits before merging
  • We generally review new PRs within a week
  • If you have any question, you can ask for feedback in our discord community first

Description

Describe your changes:

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@saviogl saviogl force-pushed the feature-correctly-parse-queue-systems branch from 86187f0 to cae5645 Compare August 25, 2025 16:08
cursor[bot]

This comment was marked as outdated.

@saviogl saviogl force-pushed the feature-correctly-parse-queue-systems branch from cae5645 to a985a2b Compare August 25, 2025 16:26
@sl0thentr0py sl0thentr0py force-pushed the feature-correctly-parse-queue-systems branch from a985a2b to 84e5905 Compare January 7, 2026 10:02
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry this slipped through the cracks, thank you for the change!

@sl0thentr0py sl0thentr0py force-pushed the feature-correctly-parse-queue-systems branch from 84e5905 to ffe9cd6 Compare January 7, 2026 10:05
Adds parsing logic for OTel spans with messaging.system attributes to properly
categorize queue operations. Producer spans get 'queue.publish' operation and
consumer spans get 'queue.process' operation. The span description is extracted
from the span name (e.g., "Sidekiq::Worker" from "Sidekiq::Worker publish").
@sl0thentr0py sl0thentr0py force-pushed the feature-correctly-parse-queue-systems branch from ffe9cd6 to 72d172d Compare January 7, 2026 10:06
@sl0thentr0py sl0thentr0py merged commit 7eda574 into getsentry:master Jan 7, 2026
135 checks passed
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.39%. Comparing base (7d10c02) to head (72d172d).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2685      +/-   ##
==========================================
+ Coverage   90.13%   90.39%   +0.25%     
==========================================
  Files         132      136       +4     
  Lines        5301     5484     +183     
==========================================
+ Hits         4778     4957     +179     
- Misses        523      527       +4     
Components Coverage Δ
sentry-ruby 97.31% <98.40%> (+0.02%) ⬆️
sentry-rails 55.50% <ø> (ø)
sentry-sidekiq 95.05% <ø> (ø)
sentry-resque 94.44% <ø> (ø)
sentry-delayed_job 94.68% <ø> (ø)
sentry-opentelemetry 99.32% <100.00%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
...lemetry/lib/sentry/opentelemetry/span_processor.rb 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants