Repository navigation
fix(ios): Find .xcode.env in the debug symbols phase under SwiftPM - #6911
Merged
Merged
Conversation
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
📲 Install BuildsAndroid
|
antonis
approved these changes
Oct 19, 2026
antonis
left a comment
Contributor
There was a problem hiding this comment.
LGTM once the tests go 🟢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
The Expo plugin "Upload Debug Symbols to Sentry" phase now uses
$SRCROOTto find.xcode.envwhenPODFILE_DIRandPODS_ROOTare not set. The order isPODFILE_DIR, thenPODS_ROOT/.., thenSRCROOT. Thus CocoaPods projects do not change.💡 Motivation and Context
After
react-native spm add --deintegrate, the project has no CocoaPods, soPODS_ROOTis empty. The phase looked for/../.xcode.envand did not findNODE_BINARY. When Xcode starts from the Dock,nodeis not onPATH, so the phase failed. The SwiftPM build phases of React Native 0.87 use$SRCROOT/.xcode.envfor the same reason.Related to #5780.
💚 How did you test it?
Added two shell tests in
modifyXcodeProject.test.ts. One runs the phase with onlySRCROOTset and nonodeonPATH. This test failed before the fix. The other test makes sure thatPODS_ROOThas priority overSRCROOT.📝 Checklist
sendDefaultPIIis enabled.