chore(deps): Bump Android SDK to v8.3.0 by antonis · Pull Request #4490 · getsentry/sentry-react-native

antonis · 2025-01-28T11:28:25Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

I've opened this PR to fix Android SDK v8.0.0 breakages and deprecations without interfering with the update-android.sh ci automation and to get a 2nd eye on the changes.

⚠️ The changes on this PR will conflict with the Android refactoring for the capture app start errors feature. I expect that porting the 5 changes/commits in the new implementation should be straightforward.

💡 Motivation and Context

Part of #4541

Migration guide from version 7.x to 8.0

Breakages

Deprecations

Replace Hub with Scopes

💚 How did you test it?

CI, Manual

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

github-actions · 2025-01-28T11:42:43Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	395.72 ms	435.51 ms	39.79 ms
Size	17.75 MiB	20.15 MiB	2.40 MiB

Previous results on branch: antonis/android-sdk-8

Startup times

Revision	Plain	With Sentry	Diff
`f703940`	437.08 ms	449.29 ms	12.21 ms
`43ce2a5`	335.96 ms	352.66 ms	16.70 ms
`9ad8411`	408.49 ms	400.63 ms	-7.86 ms
`9af1463`	403.72 ms	386.56 ms	-17.16 ms
`f107027`	383.58 ms	407.79 ms	24.21 ms
`f220e4d`	378.24 ms	431.71 ms	53.47 ms
`48d1309`	451.34 ms	470.70 ms	19.36 ms
`8f1e8e1`	468.76 ms	462.81 ms	-5.95 ms
`13aaa0b`	381.94 ms	491.94 ms	110.00 ms
`516ff9a`	449.94 ms	430.71 ms	-19.22 ms

App size

Revision	Plain	With Sentry	Diff
`f703940`	17.75 MiB	20.12 MiB	2.37 MiB
`43ce2a5`	17.75 MiB	20.13 MiB	2.38 MiB
`9ad8411`	17.75 MiB	20.15 MiB	2.40 MiB
`9af1463`	17.75 MiB	20.12 MiB	2.37 MiB
`f107027`	17.75 MiB	20.15 MiB	2.40 MiB
`f220e4d`	17.75 MiB	20.15 MiB	2.40 MiB
`48d1309`	17.75 MiB	20.15 MiB	2.40 MiB
`8f1e8e1`	17.75 MiB	20.15 MiB	2.40 MiB
`13aaa0b`	17.75 MiB	20.13 MiB	2.38 MiB
`516ff9a`	17.75 MiB	20.13 MiB	2.38 MiB

github-actions · 2025-01-28T12:26:36Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	420.29 ms	432.86 ms	12.57 ms
Size	7.15 MiB	8.41 MiB	1.26 MiB

Previous results on branch: antonis/android-sdk-8

Startup times

Revision	Plain	With Sentry	Diff
`43ce2a5`+dirty	412.87 ms	461.96 ms	49.08 ms
`516ff9a`+dirty	348.83 ms	389.59 ms	40.76 ms
`f703940`+dirty	350.96 ms	390.84 ms	39.88 ms
`8f1e8e1`+dirty	388.60 ms	424.30 ms	35.70 ms
`9af1463`+dirty	287.04 ms	313.50 ms	26.46 ms
`f220e4d`+dirty	394.08 ms	420.40 ms	26.31 ms
`f107027`+dirty	390.89 ms	411.72 ms	20.83 ms
`48d1309`+dirty	395.78 ms	408.06 ms	12.28 ms
`9ad8411`+dirty	367.73 ms	371.16 ms	3.43 ms
`13aaa0b`+dirty	382.52 ms	440.69 ms	58.17 ms

App size

Revision	Plain	With Sentry	Diff
`43ce2a5`+dirty	7.15 MiB	8.39 MiB	1.24 MiB
`516ff9a`+dirty	7.15 MiB	8.39 MiB	1.24 MiB
`f703940`+dirty	7.15 MiB	8.39 MiB	1.24 MiB
`8f1e8e1`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`9af1463`+dirty	7.15 MiB	8.39 MiB	1.24 MiB
`f220e4d`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`f107027`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`48d1309`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`9ad8411`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`13aaa0b`+dirty	7.15 MiB	8.39 MiB	1.24 MiB

github-actions · 2025-01-28T12:26:44Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1210.15 ms	1217.14 ms	7.00 ms
Size	3.19 MiB	4.31 MiB	1.12 MiB

Previous results on branch: antonis/android-sdk-8

Startup times

Revision	Plain	With Sentry	Diff
`13aaa0b`+dirty	1227.24 ms	1233.71 ms	6.47 ms
`9af1463`+dirty	1217.24 ms	1215.55 ms	-1.69 ms
`43ce2a5`+dirty	1222.30 ms	1210.89 ms	-11.40 ms
`9ad8411`+dirty	1229.31 ms	1225.35 ms	-3.96 ms
`f220e4d`+dirty	1241.67 ms	1251.04 ms	9.37 ms
`f107027`+dirty	1220.96 ms	1223.61 ms	2.65 ms
`f703940`+dirty	1227.41 ms	1221.96 ms	-5.45 ms
`516ff9a`+dirty	1236.90 ms	1232.92 ms	-3.98 ms
`8f1e8e1`+dirty	1227.39 ms	1220.58 ms	-6.81 ms
`48d1309`+dirty	1227.32 ms	1227.41 ms	0.09 ms

App size

Revision	Plain	With Sentry	Diff
`13aaa0b`+dirty	3.19 MiB	4.26 MiB	1.08 MiB
`9af1463`+dirty	3.19 MiB	4.25 MiB	1.07 MiB
`43ce2a5`+dirty	3.19 MiB	4.27 MiB	1.08 MiB
`9ad8411`+dirty	3.19 MiB	4.31 MiB	1.12 MiB
`f220e4d`+dirty	3.19 MiB	4.31 MiB	1.12 MiB
`f107027`+dirty	3.19 MiB	4.31 MiB	1.12 MiB
`f703940`+dirty	3.19 MiB	4.25 MiB	1.07 MiB
`516ff9a`+dirty	3.19 MiB	4.26 MiB	1.08 MiB
`8f1e8e1`+dirty	3.19 MiB	4.26 MiB	1.08 MiB
`48d1309`+dirty	3.19 MiB	4.31 MiB	1.12 MiB

github-actions · 2025-01-28T12:33:36Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1210.40 ms	1210.94 ms	0.54 ms
Size	2.63 MiB	3.74 MiB	1.11 MiB

Previous results on branch: antonis/android-sdk-8

Startup times

Revision	Plain	With Sentry	Diff
`13aaa0b`+dirty	1227.88 ms	1225.39 ms	-2.49 ms
`9af1463`+dirty	1231.92 ms	1232.04 ms	0.12 ms
`43ce2a5`+dirty	1228.81 ms	1221.27 ms	-7.54 ms
`9ad8411`+dirty	1226.32 ms	1234.36 ms	8.04 ms
`f220e4d`+dirty	1219.92 ms	1220.60 ms	0.68 ms
`f107027`+dirty	1225.02 ms	1232.50 ms	7.48 ms
`f703940`+dirty	1219.50 ms	1223.02 ms	3.52 ms
`516ff9a`+dirty	1210.71 ms	1219.10 ms	8.40 ms
`8f1e8e1`+dirty	1225.67 ms	1236.16 ms	10.49 ms
`48d1309`+dirty	1228.70 ms	1223.89 ms	-4.81 ms

App size

Revision	Plain	With Sentry	Diff
`13aaa0b`+dirty	2.63 MiB	3.70 MiB	1.06 MiB
`9af1463`+dirty	2.63 MiB	3.69 MiB	1.06 MiB
`43ce2a5`+dirty	2.63 MiB	3.70 MiB	1.07 MiB
`9ad8411`+dirty	2.63 MiB	3.74 MiB	1.11 MiB
`f220e4d`+dirty	2.63 MiB	3.74 MiB	1.11 MiB
`f107027`+dirty	2.63 MiB	3.74 MiB	1.11 MiB
`f703940`+dirty	2.63 MiB	3.69 MiB	1.05 MiB
`516ff9a`+dirty	2.63 MiB	3.70 MiB	1.06 MiB
`8f1e8e1`+dirty	2.63 MiB	3.70 MiB	1.06 MiB
`48d1309`+dirty	2.63 MiB	3.74 MiB	1.11 MiB

# Conflicts: # CHANGELOG.md

lucas-zimerman

The changes are looking good! LGTM!

krystofwoldrich · 2025-01-30T01:28:51Z

We should evaluate if it's okay to release this in a feature update, or wait for RN SDK v7.

Generally we don't have to do a major due to native SDK major, but we should confirm if minSdkVersion bump to 21 and others are not issue for min support RN version 0.65.

antonis · 2025-01-30T09:03:02Z

We should evaluate if it's okay to release this in a feature update, or wait for RN SDK v7.

That's a good point @krystofwoldrich 👍
Though this version bump has a long changelog my understanding from the migration guide is that it is safe to bump since the changes needed on our side were minimal.
That said it would be nice to have a confirmation from the Android team.

Generally we don't have to do a major due to native SDK major, but we should confirm if minSdkVersion bump to 21 and others are not issue for min support RN version 0.65.

Currently the react native sdk defaults to minSdk 21 (though our gradle is not enforcing that).
Given that the version 21 bump has been communicated in our v5 migration guide this might not be blocking.

# Conflicts: # CHANGELOG.md # packages/core/android/build.gradle

antonis · 2025-02-19T16:36:46Z

@krystofwoldrich , @lucas-zimerman I've targeted v7 and this is ready for another pass 🙇

lucas-zimerman

LGTM! Thank you for the PR!

krystofwoldrich

LGTM 🚀 Thank you!

web-flow and others added 5 commits January 27, 2025 11:55

chore: update scripts/update-android.sh to 8.0.0

d2b541e

Remove user segment

bcdad66

Update AndroidProfiler constructor

fa6ffeb

Use getPackageSet instead of getPackages

40f4fab

Use getIntegrationSet instead of getIntegrations

0828c2b

Replace Hub with Scopes

140ba26

antonis marked this pull request as ready for review January 28, 2025 11:57

antonis requested review from krystofwoldrich and lucas-zimerman as code owners January 28, 2025 11:57

chore: update scripts/update-android.sh to 8.0.0

0316113

bruno-garcia force-pushed the deps/scripts/update-android.sh branch from d2b541e to 0316113 Compare January 29, 2025 07:45

Merge branch 'deps/scripts/update-android.sh' into antonis/android-sdk-8

5496d80

# Conflicts: # CHANGELOG.md

lucas-zimerman approved these changes Jan 29, 2025

View reviewed changes

bruno-garcia force-pushed the deps/scripts/update-android.sh branch 2 times, most recently from fd074dc to b8e6e0d Compare January 31, 2025 05:53

chore: update scripts/update-android.sh to 8.1.0

246e13b

bruno-garcia force-pushed the deps/scripts/update-android.sh branch from b8e6e0d to 246e13b Compare January 31, 2025 07:16

Merge branch 'deps/scripts/update-android.sh' into antonis/android-sdk-8

0d54111

# Conflicts: # CHANGELOG.md # packages/core/android/build.gradle

antonis changed the title ~~chore(deps): Fixes Android SDK v8.0.0 breakages and deprecations~~ chore(deps): Fixes Android SDK v8 breakages and deprecations Jan 31, 2025

chore: update scripts/update-android.sh to 8.1.0

6f276a6

bruno-garcia force-pushed the deps/scripts/update-android.sh branch from 246e13b to 6f276a6 Compare January 31, 2025 16:32

antonis and others added 2 commits February 3, 2025 09:15

Merge branch 'deps/scripts/update-android.sh' into antonis/android-sdk-8

54130d9

chore: update scripts/update-android.sh to 8.1.0

ac72161

bruno-garcia force-pushed the deps/scripts/update-android.sh branch from 6f276a6 to ac72161 Compare February 3, 2025 07:16

antonis and others added 2 commits February 13, 2025 09:56

Merge branch 'deps/scripts/update-android.sh' into antonis/android-sdk-8

0db8c1b

chore: update scripts/update-android.sh to 8.2.0

6895033

bruno-garcia force-pushed the deps/scripts/update-android.sh branch from 93220a5 to 6895033 Compare February 14, 2025 09:15

Merge branch 'deps/scripts/update-android.sh' into antonis/android-sdk-8

e700367

bruno-garcia force-pushed the deps/scripts/update-android.sh branch 4 times, most recently from 1f6a33c to ebea685 Compare February 18, 2025 08:16

chore: update scripts/update-android.sh to 8.2.0

d50515c

bruno-garcia force-pushed the deps/scripts/update-android.sh branch from ebea685 to d50515c Compare February 18, 2025 09:17

Merge branch 'deps/scripts/update-android.sh' into antonis/android-sdk-8

b31ccdc

bruno-garcia force-pushed the deps/scripts/update-android.sh branch 2 times, most recently from edf3857 to 8007f1b Compare February 19, 2025 10:32

antonis changed the base branch from deps/scripts/update-android.sh to v7 February 19, 2025 15:06

Merge branch 'v7' into antonis/android-sdk-8

88646ba

antonis requested a review from lucas-zimerman February 19, 2025 16:35

antonis changed the title ~~chore(deps): Fixes Android SDK v8 breakages and deprecations~~ chore(deps): Bump Android SDK to v8.2.0 Feb 20, 2025

lucas-zimerman approved these changes Feb 25, 2025

View reviewed changes

antonis mentioned this pull request Feb 27, 2025

chore(deps): Bump Android SDK to v8.3.0 #4607

Merged

10 tasks

Bump Android SDK to 8.3.0 (#4607)

08e9e8f

antonis changed the title ~~chore(deps): Bump Android SDK to v8.2.0~~ chore(deps): Bump Android SDK to v8.3.0 Mar 4, 2025

Merge branch 'v7' into antonis/android-sdk-8

7db540e

This was referenced Mar 5, 2025

chore(deps): update Android SDK to v8.20.0 #4471

Closed

[React-Native]: v7 #4541

Closed

Merge branch 'v7' into antonis/android-sdk-8

a66d919

krystofwoldrich approved these changes Mar 13, 2025

View reviewed changes

krystofwoldrich merged commit f5a43d3 into v7 Mar 13, 2025
66 checks passed

krystofwoldrich deleted the antonis/android-sdk-8 branch March 13, 2025 10:25

antonis mentioned this pull request Mar 21, 2025

feat(React Native) Add react native V7 migration getsentry/sentry-docs#13025

Merged

6 tasks

Uh oh!

Conversation

antonis commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

Breakages

Deprecations

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Previous results on branch: antonis/android-sdk-8

Startup times

App size

Uh oh!

github-actions bot commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Previous results on branch: antonis/android-sdk-8

Startup times

App size

Uh oh!

github-actions bot commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Previous results on branch: antonis/android-sdk-8

Startup times

App size

Uh oh!

github-actions bot commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Previous results on branch: antonis/android-sdk-8

Startup times

App size

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

krystofwoldrich commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antonis commented Jan 30, 2025

Uh oh!

antonis commented Feb 19, 2025

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

krystofwoldrich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

antonis commented Jan 28, 2025 •

edited

Loading

github-actions bot commented Jan 28, 2025 •

edited

Loading

github-actions bot commented Jan 28, 2025 •

edited

Loading

github-actions bot commented Jan 28, 2025 •

edited

Loading

github-actions bot commented Jan 28, 2025 •

edited

Loading

krystofwoldrich commented Jan 30, 2025 •

edited

Loading