Repository navigation
ref(boto3): Rename span origin to auto.aws.boto3 - #8034
Open
pabloDeputter wants to merge 1 commit into
Open
pabloDeputter wants to merge 1 commit into
pabloDeputter wants to merge 1 commit into
Conversation
pabloDeputter
marked this pull request as ready for review
October 14, 2026 16:00
Contributor
Coverage Results 📊✅ 56047 passed | ❌ 1 failed | ⏭️ 2872 skipped | Total: 58920 | Pass Rate: 95.12% | Execution Time: 159m 28s 📊 Comparison with Base Branch
➕ New Tests (1)View new tests
❌ Failed Tests
|
| File | Patch coverage | Changed executable lines |
|---|---|---|
| sentry_sdk/integrations/boto3/consts.py | 100.00% | 1/1 covered |
Coverage diff
@@ Coverage Diff @@
## master #8034 +/-##
==========================================
- Coverage 90.26% 90.04% -0.22%
==========================================
Files 202 193 -9
Tracked lines 26660 20931 -5729
Branches 9926 7206 -2720
==========================================
- Hits 24063 18846 -5217
+ Misses 2597 2085 -512
+ Partials 1510 1233 -277Generated by Coverage Action
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename the boto3 span origin from
auto.http.boto3toauto.aws.boto3, for every boto3 span including the streamed response body child, and removes the unusedget_span_origin()method from_ServiceExtension.(todo: to be added to migration guide if we change it)
Why
auto.http.boto3describes the underlying transport/integration used; boto3 spans are AWS API calls, and (in the future) the ops will be changed fromhttp.client=>rpc,db,queue.*,object.*, so it doesn't really fit anymore.auto.aws.aws_sdk.Other option
The other option is to use
auto.rpc.boto3as the default origin (sinceawsisn't technically part of the categories, even though JS uses it https://develop.sentry.dev/sdk/telemetry/traces/trace-origin/) and override it with the span's op for different services:db=>auto.db.boto3queue.*=>auto.queue.boto3object.*=>auto.object.boto3http.client.stream=>auto.http.boto3