Skip to content

ref(boto3): Rename span origin to auto.aws.boto3 - #8034

Open
pabloDeputter wants to merge 1 commit into
major/3.0from
pablo/boto3-aws-origin
Open

pabloDeputter wants to merge 1 commit into
major/3.0from
pablo/boto3-aws-origin

Conversation

@pabloDeputter

Copy link
Copy Markdown
Member

Description

Rename the boto3 span origin from auto.http.boto3 to auto.aws.boto3, for every boto3 span including the streamed response body child, and removes the unused get_span_origin() method from _ServiceExtension.
(todo: to be added to migration guide if we change it)

Why

  1. auto.http.boto3 describes the underlying transport/integration used; boto3 spans are AWS API calls, and (in the future) the ops will be changed from http.client => rpc, db, queue.*, object.*, so it doesn't really fit anymore.
  2. JS does the same and uses auto.aws.aws_sdk.

Other option

The other option is to use auto.rpc.boto3 as the default origin (since aws isn't technically part of the categories, even though JS uses it https://develop.sentry.dev/sdk/telemetry/traces/trace-origin/) and override it with the span's op for different services:

  • db => auto.db.boto3
  • queue.* => auto.queue.boto3
  • object.* => auto.object.boto3
  • streamed body child has op http.client.stream => auto.http.boto3

@pabloDeputter
pabloDeputter marked this pull request as ready for review October 14, 2026 16:00
@pabloDeputter
pabloDeputter requested a review from a team as a code owner October 14, 2026 16:00
@github-actions

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 56047 passed | ❌ 1 failed | ⏭️ 2872 skipped | Total: 58920 | Pass Rate: 95.12% | Execution Time: 159m 28s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -82022
Passed Tests 📉 -77619
Failed Tests 📈 +1
Skipped Tests 📉 -4404

➕ New Tests (1)

View new tests
  • test_cache_spans_decorator
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing

❌ Failed Tests

test_cache_spans_decorator

File: tests.integrations.django.test_cache_module
Suite: py3.13-django-v5.2.18
Error: tests/integrations/django/test_cache_module.py:307: in test_cache_spans_decorator assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:307: in test_cache_spans_decorator
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

✅ Patch coverage is 100.00% (1 of 1 changed executable lines covered; target 80%).
Project statement coverage is 90.04% (down 0.22 percentage points from base (d22300b) to head (52b2be0)).

Changed files with executable lines (1)
File Patch coverage Changed executable lines
sentry_sdk/integrations/boto3/consts.py 100.00% 1/1 covered
Coverage diff
@@            Coverage Diff             @@
##        master     #8034       +/-##
==========================================
- Coverage    90.26%    90.04%    -0.22%
==========================================
  Files          202       193        -9
  Tracked lines     26660     20931     -5729
  Branches      9926      7206     -2720
==========================================
- Hits         24063     18846     -5217
+ Misses        2597      2085      -512
+ Partials      1510      1233      -277

Generated by Coverage Action

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant