chore: Drop enable_logs, enable_metrics options in new major - #7178
Conversation
Codecov Results 📊✅ 110340 passed | ❌ 2 failed | ⏭️ 5428 skipped | Total: 115770 | Pass Rate: 95.31% | Execution Time: 385m 1s 📊 Comparison with Base Branch
➕ New Tests (2)View new tests
❌ Failed Tests
|
ericapisani
left a comment
There was a problem hiding this comment.
Other than the one note for our guidance in the migration guide, this LGTM
| - Removed the RedisIntegration `max_data_size` option. | ||
| - Removed the possibility to supply a specific client to the LaunchDarklyIntegration. | ||
| - The `enable_tracing` option was removed. Use `traces_sample_rate=1.0` instead. | ||
| - The `enable_logs` option was removed. Using Sentry's logging API now works without requiring setting `enable_logs=True`. Automatic capture of logs emitted by the `logging` standard library module or Loguru can be turned on by providing the `capture_sentry_logs=True` option to either `LoggingIntegration` or `LoguruIntegration`: |
There was a problem hiding this comment.
Automatic capture of logs emitted by the
loggingstandard library module or Loguru can be turned on by providing thecapture_sentry_logs=Trueoption to eitherLoggingIntegrationorLoguruIntegration
GivenLoggingIntegration and LoguruIntegration are both auto-enabling integrations, I wonder if it might be more useful to give an example for opting out rather than opting in.
There was a problem hiding this comment.
They're auto-enabling for errors, but they won't start capturing logs unless you explicitly opt in. So no logs is default behavior, and if you want logs, you need to explicitly enable that.
There was a problem hiding this comment.
Also, status update 🤦🏻♀️ but this will change in a later PR. Will leave this as is as it captures the current state and will update it in the follow up PR.
The options were deprecated with 2fef9bc.