Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 20 additions & 19 deletions .github/workflows/test-integrations-agents.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,23 +33,30 @@ jobs:
fail-fast: false
matrix:
python-version: ["3.10","3.11","3.12","3.13","3.14","3.14t"]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-22.04]
# Use Docker container only for Python 3.6
container: ${{ matrix.python-version == '3.6' && 'python:3.6' || null }}
env:
# 3.6/3.7 run in the python:X.Y container; tell uv to use that system Python.
UV_PYTHON_PREFERENCE: ${{ (matrix.python-version == '3.6' || matrix.python-version == '3.7') && 'only-system' || 'managed' }}
container: ${{ (matrix.python-version == '3.6' || matrix.python-version == '3.7') && format('python:{0}', matrix.python-version) || null }}
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6
if: ${{ matrix.python-version != '3.6' }}
with:
python-version: ${{ matrix.python-version }}
allow-prereleases: true
- name: Install uv
uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
- name: Mark workspace safe for git (3.6/3.7 container)
# actions/checkout sets safe.directory under a temporary HOME that is
# discarded after the step, so the workspace is again "dubious ownership"
# for later steps. Re-add it under the container's real HOME so that
# subprocesses (e.g. sentry_sdk.utils.get_git_revision) can run git.
if: ${{ matrix.python-version == '3.6' || matrix.python-version == '3.7' }}
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
- name: Setup Test Env
# Pin tox + coverage to uv-managed Python 3.13 even when the job sets
# UV_PYTHON_PREFERENCE=only-system for 3.6/3.7 (which only applies to tox-uv at test time).
env:
UV_PYTHON_PREFERENCE: managed
run: |
pip install "coverage[toml]" tox
uv tool install --python 3.13 --with tox-uv tox
uv tool install --python 3.13 "coverage[toml]"
- name: Erase coverage
run: |
coverage erase
Expand All @@ -61,14 +68,8 @@ jobs:
run: |
set -x # print commands that are executed
./scripts/runtox.sh "py${{ matrix.python-version }}-pydantic_ai"
- name: Generate coverage XML (Python 3.6)
if: ${{ !cancelled() && matrix.python-version == '3.6' }}
run: |
export COVERAGE_RCFILE=.coveragerc36
coverage combine .coverage-sentry-*
coverage xml --ignore-errors
- name: Generate coverage XML
if: ${{ !cancelled() && matrix.python-version != '3.6' }}
if: ${{ !cancelled() }}
run: |
coverage combine .coverage-sentry-*
coverage xml
Expand Down
39 changes: 20 additions & 19 deletions .github/workflows/test-integrations-ai-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,23 +33,30 @@ jobs:
fail-fast: false
matrix:
python-version: ["3.9","3.10","3.11","3.12","3.13","3.14"]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-22.04]
# Use Docker container only for Python 3.6
container: ${{ matrix.python-version == '3.6' && 'python:3.6' || null }}
env:
# 3.6/3.7 run in the python:X.Y container; tell uv to use that system Python.
UV_PYTHON_PREFERENCE: ${{ (matrix.python-version == '3.6' || matrix.python-version == '3.7') && 'only-system' || 'managed' }}
container: ${{ (matrix.python-version == '3.6' || matrix.python-version == '3.7') && format('python:{0}', matrix.python-version) || null }}
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6
if: ${{ matrix.python-version != '3.6' }}
with:
python-version: ${{ matrix.python-version }}
allow-prereleases: true
- name: Install uv
uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
- name: Mark workspace safe for git (3.6/3.7 container)
# actions/checkout sets safe.directory under a temporary HOME that is
# discarded after the step, so the workspace is again "dubious ownership"
# for later steps. Re-add it under the container's real HOME so that
# subprocesses (e.g. sentry_sdk.utils.get_git_revision) can run git.
if: ${{ matrix.python-version == '3.6' || matrix.python-version == '3.7' }}
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
- name: Setup Test Env
# Pin tox + coverage to uv-managed Python 3.13 even when the job sets
# UV_PYTHON_PREFERENCE=only-system for 3.6/3.7 (which only applies to tox-uv at test time).
env:
UV_PYTHON_PREFERENCE: managed
run: |
pip install "coverage[toml]" tox
uv tool install --python 3.13 --with tox-uv tox
uv tool install --python 3.13 "coverage[toml]"
- name: Erase coverage
run: |
coverage erase
Expand All @@ -65,14 +72,8 @@ jobs:
run: |
set -x # print commands that are executed
./scripts/runtox.sh "py${{ matrix.python-version }}-langgraph"
- name: Generate coverage XML (Python 3.6)
if: ${{ !cancelled() && matrix.python-version == '3.6' }}
run: |
export COVERAGE_RCFILE=.coveragerc36
coverage combine .coverage-sentry-*
coverage xml --ignore-errors
- name: Generate coverage XML
if: ${{ !cancelled() && matrix.python-version != '3.6' }}
if: ${{ !cancelled() }}
run: |
coverage combine .coverage-sentry-*
coverage xml
Expand Down
39 changes: 20 additions & 19 deletions .github/workflows/test-integrations-ai.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,23 +33,30 @@ jobs:
fail-fast: false
matrix:
python-version: ["3.8","3.9","3.10","3.11","3.12","3.13","3.14","3.14t"]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-22.04]
# Use Docker container only for Python 3.6
container: ${{ matrix.python-version == '3.6' && 'python:3.6' || null }}
env:
# 3.6/3.7 run in the python:X.Y container; tell uv to use that system Python.
UV_PYTHON_PREFERENCE: ${{ (matrix.python-version == '3.6' || matrix.python-version == '3.7') && 'only-system' || 'managed' }}
container: ${{ (matrix.python-version == '3.6' || matrix.python-version == '3.7') && format('python:{0}', matrix.python-version) || null }}
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6
if: ${{ matrix.python-version != '3.6' }}
with:
python-version: ${{ matrix.python-version }}
allow-prereleases: true
- name: Install uv
uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
- name: Mark workspace safe for git (3.6/3.7 container)
# actions/checkout sets safe.directory under a temporary HOME that is
# discarded after the step, so the workspace is again "dubious ownership"
# for later steps. Re-add it under the container's real HOME so that
# subprocesses (e.g. sentry_sdk.utils.get_git_revision) can run git.
if: ${{ matrix.python-version == '3.6' || matrix.python-version == '3.7' }}
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
- name: Setup Test Env
# Pin tox + coverage to uv-managed Python 3.13 even when the job sets
# UV_PYTHON_PREFERENCE=only-system for 3.6/3.7 (which only applies to tox-uv at test time).
env:
UV_PYTHON_PREFERENCE: managed
run: |
pip install "coverage[toml]" tox
uv tool install --python 3.13 --with tox-uv tox
uv tool install --python 3.13 "coverage[toml]"
- name: Erase coverage
run: |
coverage erase
Expand Down Expand Up @@ -81,14 +88,8 @@ jobs:
run: |
set -x # print commands that are executed
./scripts/runtox.sh "py${{ matrix.python-version }}-openai-notiktoken"
- name: Generate coverage XML (Python 3.6)
if: ${{ !cancelled() && matrix.python-version == '3.6' }}
run: |
export COVERAGE_RCFILE=.coveragerc36
coverage combine .coverage-sentry-*
coverage xml --ignore-errors
- name: Generate coverage XML
if: ${{ !cancelled() && matrix.python-version != '3.6' }}
if: ${{ !cancelled() }}
run: |
coverage combine .coverage-sentry-*
coverage xml
Expand Down
39 changes: 20 additions & 19 deletions .github/workflows/test-integrations-cloud.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,27 +33,34 @@ jobs:
fail-fast: false
matrix:
python-version: ["3.6","3.7","3.8","3.9","3.10","3.11","3.12","3.13","3.14","3.14t"]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-22.04]
services:
docker:
image: docker:dind # Required for Docker network management
options: --privileged # Required for Docker-in-Docker operations
# Use Docker container only for Python 3.6
container: ${{ matrix.python-version == '3.6' && 'python:3.6' || null }}
env:
# 3.6/3.7 run in the python:X.Y container; tell uv to use that system Python.
UV_PYTHON_PREFERENCE: ${{ (matrix.python-version == '3.6' || matrix.python-version == '3.7') && 'only-system' || 'managed' }}
container: ${{ (matrix.python-version == '3.6' || matrix.python-version == '3.7') && format('python:{0}', matrix.python-version) || null }}
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6
if: ${{ matrix.python-version != '3.6' }}
with:
python-version: ${{ matrix.python-version }}
allow-prereleases: true
- name: Install uv
uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
- name: Mark workspace safe for git (3.6/3.7 container)
# actions/checkout sets safe.directory under a temporary HOME that is
# discarded after the step, so the workspace is again "dubious ownership"
# for later steps. Re-add it under the container's real HOME so that
# subprocesses (e.g. sentry_sdk.utils.get_git_revision) can run git.
if: ${{ matrix.python-version == '3.6' || matrix.python-version == '3.7' }}
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
- name: Setup Test Env
# Pin tox + coverage to uv-managed Python 3.13 even when the job sets
# UV_PYTHON_PREFERENCE=only-system for 3.6/3.7 (which only applies to tox-uv at test time).
env:
UV_PYTHON_PREFERENCE: managed
run: |
pip install "coverage[toml]" tox
uv tool install --python 3.13 --with tox-uv tox
uv tool install --python 3.13 "coverage[toml]"
- name: Erase coverage
run: |
coverage erase
Expand All @@ -77,14 +84,8 @@ jobs:
run: |
set -x # print commands that are executed
./scripts/runtox.sh "py${{ matrix.python-version }}-gcp"
- name: Generate coverage XML (Python 3.6)
if: ${{ !cancelled() && matrix.python-version == '3.6' }}
run: |
export COVERAGE_RCFILE=.coveragerc36
coverage combine .coverage-sentry-*
coverage xml --ignore-errors
- name: Generate coverage XML
if: ${{ !cancelled() && matrix.python-version != '3.6' }}
if: ${{ !cancelled() }}
run: |
coverage combine .coverage-sentry-*
coverage xml
Expand Down
39 changes: 20 additions & 19 deletions .github/workflows/test-integrations-common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,38 +33,39 @@ jobs:
fail-fast: false
matrix:
python-version: ["3.6","3.7","3.8","3.9","3.10","3.11","3.12","3.13","3.14","3.14t"]
Comment thread
sl0thentr0py marked this conversation as resolved.
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-22.04]
# Use Docker container only for Python 3.6
container: ${{ matrix.python-version == '3.6' && 'python:3.6' || null }}
env:
# 3.6/3.7 run in the python:X.Y container; tell uv to use that system Python.
UV_PYTHON_PREFERENCE: ${{ (matrix.python-version == '3.6' || matrix.python-version == '3.7') && 'only-system' || 'managed' }}
container: ${{ (matrix.python-version == '3.6' || matrix.python-version == '3.7') && format('python:{0}', matrix.python-version) || null }}
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6
if: ${{ matrix.python-version != '3.6' }}
with:
python-version: ${{ matrix.python-version }}
allow-prereleases: true
- name: Install uv
uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
- name: Mark workspace safe for git (3.6/3.7 container)
# actions/checkout sets safe.directory under a temporary HOME that is
# discarded after the step, so the workspace is again "dubious ownership"
# for later steps. Re-add it under the container's real HOME so that
# subprocesses (e.g. sentry_sdk.utils.get_git_revision) can run git.
if: ${{ matrix.python-version == '3.6' || matrix.python-version == '3.7' }}
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
- name: Setup Test Env
# Pin tox + coverage to uv-managed Python 3.13 even when the job sets
# UV_PYTHON_PREFERENCE=only-system for 3.6/3.7 (which only applies to tox-uv at test time).
env:
UV_PYTHON_PREFERENCE: managed
run: |
pip install "coverage[toml]" tox
uv tool install --python 3.13 --with tox-uv tox
uv tool install --python 3.13 "coverage[toml]"
- name: Erase coverage
run: |
coverage erase
- name: Test common
run: |
set -x # print commands that are executed
./scripts/runtox.sh "py${{ matrix.python-version }}-common"
- name: Generate coverage XML (Python 3.6)
if: ${{ !cancelled() && matrix.python-version == '3.6' }}
run: |
export COVERAGE_RCFILE=.coveragerc36
coverage combine .coverage-sentry-*
coverage xml --ignore-errors
- name: Generate coverage XML
if: ${{ !cancelled() && matrix.python-version != '3.6' }}
if: ${{ !cancelled() }}
run: |
coverage combine .coverage-sentry-*
coverage xml
Expand Down
40 changes: 20 additions & 20 deletions .github/workflows/test-integrations-dbs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@
fail-fast: false
matrix:
python-version: ["3.6","3.7","3.8","3.9","3.10","3.11","3.12","3.13","3.14","3.14t"]
# python3.6 reached EOL and is no longer being supported on
# new versions of hosted runners on Github Actions
# ubuntu-20.04 is the last version that supported python3.6
# see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877
os: [ubuntu-22.04]
services:
postgres:
Expand All @@ -53,23 +49,33 @@
ports:
- 5432:5432
env:
SENTRY_PYTHON_TEST_POSTGRES_HOST: ${{ matrix.python-version == '3.6' && 'postgres' || 'localhost' }}
# 3.6/3.7 run in the python:X.Y container; tell uv to use that system Python.
UV_PYTHON_PREFERENCE: ${{ (matrix.python-version == '3.6' || matrix.python-version == '3.7') && 'only-system' || 'managed' }}

Check failure on line 53 in .github/workflows/test-integrations-dbs.yml

View check run for this annotation

@sentry/warden / warden: code-review

uv/tox-uv may reject Python 3.6 as a venv target, breaking all py3.6 tox environments

After this PR, tox provisions environments via `tox-uv` (`uv venv`). uv's supported Python target range starts at 3.7 (and recent uv releases warn/refuse for very old versions); `UV_PYTHON_PREFERENCE=only-system` only controls Python *discovery* (use system Python instead of downloading a managed one), it does not extend the set of versions uv accepts as a target. The matrix and `tox.ini` still contain `py3.6` envs (e.g. `{py3.6,...}-common`, `{py3.6,...}-gevent`, `{py3.6,...}-cloud_resource_context`, `{py3.6,...}-boto3-...`). Have you confirmed that `uv venv` + `uv pip install` actually succeed against the `python:3.6` container with the tox-uv version being used, or should the 3.6 cells be dropped / kept on pip?
SENTRY_PYTHON_TEST_POSTGRES_HOST: ${{ (matrix.python-version == '3.6' || matrix.python-version == '3.7') && 'postgres' || 'localhost' }}
SENTRY_PYTHON_TEST_POSTGRES_USER: postgres
SENTRY_PYTHON_TEST_POSTGRES_PASSWORD: sentry
# Use Docker container only for Python 3.6
container: ${{ matrix.python-version == '3.6' && 'python:3.6' || null }}
container: ${{ (matrix.python-version == '3.6' || matrix.python-version == '3.7') && format('python:{0}', matrix.python-version) || null }}
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6
if: ${{ matrix.python-version != '3.6' }}
with:
python-version: ${{ matrix.python-version }}
allow-prereleases: true
- name: Install uv
uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
- name: "Setup ClickHouse Server"
uses: getsentry/action-clickhouse-in-ci@5dc8a6a50d689bd6051db0241f34849e5a36490b # v1.7
- name: Mark workspace safe for git (3.6/3.7 container)
# actions/checkout sets safe.directory under a temporary HOME that is
# discarded after the step, so the workspace is again "dubious ownership"
# for later steps. Re-add it under the container's real HOME so that
# subprocesses (e.g. sentry_sdk.utils.get_git_revision) can run git.
if: ${{ matrix.python-version == '3.6' || matrix.python-version == '3.7' }}
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
- name: Setup Test Env
# Pin tox + coverage to uv-managed Python 3.13 even when the job sets
# UV_PYTHON_PREFERENCE=only-system for 3.6/3.7 (which only applies to tox-uv at test time).
env:
UV_PYTHON_PREFERENCE: managed
run: |
pip install "coverage[toml]" tox
uv tool install --python 3.13 --with tox-uv tox
uv tool install --python 3.13 "coverage[toml]"
- name: Erase coverage
run: |
coverage erase
Expand Down Expand Up @@ -97,14 +103,8 @@
run: |
set -x # print commands that are executed
./scripts/runtox.sh "py${{ matrix.python-version }}-sqlalchemy"
- name: Generate coverage XML (Python 3.6)
if: ${{ !cancelled() && matrix.python-version == '3.6' }}
run: |
export COVERAGE_RCFILE=.coveragerc36
coverage combine .coverage-sentry-*
coverage xml --ignore-errors
- name: Generate coverage XML
if: ${{ !cancelled() && matrix.python-version != '3.6' }}
if: ${{ !cancelled() }}
run: |
coverage combine .coverage-sentry-*
coverage xml
Expand Down
Loading
Loading