Conversation
Codecov Results 📊✅ 32 passed | Total: 32 | Pass Rate: 100% | Execution Time: 300ms All tests are passing successfully. ❌ Patch coverage is 35.29%. Project has 15005 uncovered lines. Files with missing lines (2)
Generated by Codecov Action |
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| def start_streamed_span( | ||
| self, | ||
| name: str, | ||
| attributes: "Optional[Attributes]" = None, | ||
| parent_span: "Optional[StreamedSpan]" = None, | ||
| active: bool = True, | ||
| ) -> "StreamedSpan": |
There was a problem hiding this comment.
Is there any way to explicitly create a span with is_segment=True?
There was a problem hiding this comment.
There is and this PR doesn't implement it correctly. Will fix.
The supported way to do that is to explicitly provide start_span(parent_span=None). The way it's implemented now in this PR, we don't distinguish between a user-set parent_span=None and the fallback value of None, which will actually try to parent the span to the currently active span. We'll need a different sentinel value for parent_span so that we can tell it apart from parent_span=None.
2 participants
Description
Add
sentry_sdk.traces.start_spanand the corresponding scope method.NOTE: This is experimental and not production ready code.
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)