Skip to content

test(openai-agents): Remove test for unreachable state#5584

Open
alexander-alderman-webb wants to merge 4 commits intomasterfrom
webb/openai-agents/remove-impossible-test
Open

test(openai-agents): Remove test for unreachable state#5584
alexander-alderman-webb wants to merge 4 commits intomasterfrom
webb/openai-agents/remove-impossible-test

Conversation

@alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Mar 4, 2026

Description

The openai-agents integration only attaches the response model for openai models. The response model is always included in the response payload for Completions and Responses APIs. See

# Wrap _fetch_response if it exists (for OpenAI models) to capture response model

The test specifically patches an openai function, so it tests a scenario that cannot occur.

Issues

Reminders

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

  • (celery) Propagate user-set headers by sentrivana in #5581
  • (utils) Avoid double serialization of strings in safe_serialize by ericapisani in #5587

Documentation 📚

  • (openai-agents) Remove inapplicable comment by alexander-alderman-webb in #5495
  • Add AGENTS.md by sentrivana in #5579
  • Add set_attribute example to changelog by sentrivana in #5578

Internal Changes 🔧

Openai Agents

  • Remove test for unreachable state by alexander-alderman-webb in #5584
  • Expect namespace tool field for new openai versions by alexander-alderman-webb in #5599

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Codecov Results 📊

13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 7.58s

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 13797 uncovered lines.


Generated by Codecov Action

@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review March 6, 2026 12:22
@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner March 6, 2026 12:22
Copy link
Member

@ericapisani ericapisani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants