fix: document null as an accepted metric attribute value - #2185
Open
JulienChavee wants to merge 1 commit into
Open
fix: document null as an accepted metric attribute value#2185JulienChavee wants to merge 1 commit into
JulienChavee wants to merge 1 commit into
Conversation
JulienChavee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Attribute::tryFromValue()already acceptsnulland converts it to the string"null", but the public metric attribute type declarations (array<string, int|float|string|bool>) excludednull. This meant static analysis rejectednullattribute values even though they work correctly at runtime, forcing callers (and wrapper implementations) to suppress type errors.Issues
resolves: #2182