perf(native): optimize Windows stack walking - #2018
Open
jpnurmi wants to merge 2 commits into
Open
Conversation
Open the crashed process and initialize DbgHelp once while building the native event, then reuse the same symbol-handler session for every captured thread. Clean up the session after all thread stacktraces have been extracted. Keep the existing module search path active after initializing the shared handler. This avoids repeatedly opening the target process, loading module and symbol state, and tearing DbgHelp down for every thread. Demote high-volume per-frame, per-thread, per-module, and symbol-candidate diagnostics to trace level so debug-log formatting and I/O do not inflate crash processing time or flood the log.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2018 +/- ##
==========================================
+ Coverage 74.35% 74.36% +0.01%
==========================================
Files 104 104
Lines 26518 26527 +9
Branches 4824 4827 +3
==========================================
+ Hits 19717 19728 +11
+ Misses 5454 5451 -3
- Partials 1347 1348 +1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open the crashed process and initialize
DbgHelponce while building the native event, then reuse the same symbol-handler session for every captured thread. Clean up the session after all thread stacktraces have been extracted.Keep the existing module search path active after initializing the shared handler. This avoids repeatedly opening the target process, loading module and symbol state, and tearing
DbgHelpdown for every thread.Demote high-volume per-frame, per-thread, per-module, and symbol-candidate diagnostics to trace level so that debug-log formatting and I/O do not inflate crash-processing time or flood the log.
With synthetic 128 workers with a stack depth of 128: