Skip to content

test(windows): cover invalid-parameter crashes - #2016

Open
jpnurmi wants to merge 1 commit into
masterfrom
jpnurmi/test/invalid-parameter
Open

test(windows): cover invalid-parameter crashes#2016
jpnurmi wants to merge 1 commit into
masterfrom
jpnurmi/test/invalid-parameter

Conversation

@jpnurmi

@jpnurmi jpnurmi commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Both crashpad and native capture invalid-parameter errors via WER:

(.venv) C:\Users\jpnurmi\Projects\sentry\sentry-native>pytest --with_wer -v tests\ -k "invalid-parameter"
=================================================================== test session starts ====================================================================
platform win32 -- Python 3.13.3, pytest-9.0.3, pluggy-1.6.0 -- C:\Users\jpnurmi\Projects\sentry\sentry-native\.venv\Scripts\python.exe
cachedir: .pytest_cache
rootdir: C:\Users\jpnurmi\Projects\sentry\sentry-native
plugins: flaky-3.8.1, pytest_httpserver-1.0.10, xdist-3.8.0
collected 2020 items / 2018 deselected / 2 selected

tests/test_integration_crashpad.py::test_crashpad_wer_crash[invalid-parameter] PASSED                                                                 [ 50%]
tests/test_integration_native.py::test_native_wer_crash[invalid-parameter] PASSED                                                                     [100%]

Close: #327

@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.15%. Comparing base (162f97a) to head (8cd9cd6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2016      +/-   ##
==========================================
- Coverage   74.35%   74.15%   -0.20%     
==========================================
  Files         104      104              
  Lines       26518    26518              
  Branches     4824     4824              
==========================================
- Hits        19717    19665      -52     
- Misses       5454     5515      +61     
+ Partials     1347     1338       -9     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jpnurmi
jpnurmi marked this pull request as ready for review August 24, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crashpad not capturing invalid_parameter errors on Windows

1 participant