feat(ndk): Forward enable_logs option to sentry-native - #1971
Merged
Conversation
Add `enableLogs` field to `NdkOptions` and wire it through the JNI bridge so the Android SDK can forward the user's logs configuration to the native layer. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
3 tasks
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
JoshuaMoelans
approved these changes
Aug 10, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1971 +/- ##
==========================================
+ Coverage 76.15% 76.18% +0.03%
==========================================
Files 94 94
Lines 22216 22216
Branches 3941 3941
==========================================
+ Hits 16919 16926 +7
+ Misses 4411 4395 -16
- Partials 886 895 +9 🚀 New features to boost your workflow:
|
Collaborator
|
There's an ongoing effort to remove |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enableLogsfield (+ setter/getter) toNdkOptionssentry_options_set_enable_logs()in the JNIinitSentryNativebridgeThis allows the Android SDK to forward
SentryOptions.Logs.isEnabled()to the native layer, unblockingsentry_log_*()calls from native code on Android.Ref: getsentry/sentry-java#5911
Test plan
logs.enabled = trueinSentryAndroidOptionslogs.enabled = false(default)🤖 Generated with Claude Code