Repository navigation
fix(browser): Apply urlQueryParams to breadcrumb and element timing URLs - #25289
Merged
Conversation
… URLs The fetch, XHR and navigation breadcrumbs and the `ui.element.url` attribute of `elementTimingIntegration` still sent sensitive query values such as `?token=...` to Sentry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
added this pull request to stack #25291
October 12, 2026 13:36
Member
Author
|
bugbot run |
JPeer264
marked this pull request as ready for review
October 12, 2026 13:37
JPeer264
requested review from
Lms24,
logaretm and
msonnb
and removed request for
a team
October 12, 2026 13:37
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1aa2891. Configure here.
| from, | ||
| to, | ||
| from: filterCollectedUrl(from), | ||
| to: filterCollectedUrl(to), |
There was a problem hiding this comment.
filterCollectedUrl omits in-scope client
Low Severity
This is more an "is this necessary" check than a functional break: filterCollectedUrl is called without the in-scope client, so it falls back to getClient(). The review guidelines ask to pass the client when one is available so dataCollection.urlQueryParams comes from the owning client, not the current scope. Flagged because that rule is in the review rules file.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 1aa2891. Configure here.
Contributor
size-limit report 📦
|
msonnb
approved these changes
Oct 12, 2026
JPeer264
deleted the
jp/browser-breadcrumb-element-timing-query-params
branch
October 12, 2026 14:18
47 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #25262
This applies
dataCollection.urlQueryParamsto the URLs in the fetch, XHR and navigation breadcrumbs and to theui.element.urlattribute ofelementTimingIntegration. These still sent sensitive query values such as?jwt=...to Sentry.Sentry events
Before (11.6.0),
jwt=sensitive-jwt-valuein the breadcrumbs: https://sentry-sdks.sentry.io/issues/7787761489/events/2bfc6630501c4314bf84b884a4afb1e9/After (this PR),
jwt=[Filtered]: https://sentry-sdks.sentry.io/issues/7787761463/events/6ae067a147b84e6eb33553ae7ce217c7/