Skip to content

fix(core): Don't mark http client spans as errors when the caller aborts - #25260

Merged
andreiborza merged 1 commit into
developfrom
ab/http-client-abort-not-error
Oct 12, 2026
Merged

andreiborza merged 1 commit into
developfrom
ab/http-client-abort-not-error

Conversation

@andreiborza

Copy link
Copy Markdown
Member

What

Outgoing node:http spans no longer get an error status when the caller aborts the request (for example with AbortController.abort()). If a response already arrived, the span keeps the status of that response.

Why

A caller abort is not a request failure, and it showed false http.client errors (for example for axios cancellation). This matches the fetch fix in #25129.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 29.82 kB - -
@sentry/browser - with treeshaking flags 27.95 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 27.86 kB - -
@sentry/browser (incl. Tracing) 51.88 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 51.9 kB - -
@sentry/browser (incl. Tracing, Profiling) 54.83 kB - -
@sentry/browser (incl. Tracing, Replay) 91.65 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 80.5 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 96.37 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 109.33 kB - -
@sentry/browser (incl. Feedback) 47.34 kB - -
@sentry/browser (incl. sendFeedback) 34.87 kB - -
@sentry/browser (incl. FeedbackAsync) 39.98 kB - -
@sentry/browser (incl. Metrics) 30.84 kB - -
@sentry/browser (incl. Logs) 31.13 kB - -
@sentry/browser (incl. Metrics & Logs) 31.77 kB - -
@sentry/react 31.65 kB - -
@sentry/react (incl. Tracing) 54.21 kB - -
@sentry/vue 37.89 kB - -
@sentry/vue (incl. Tracing) 54.81 kB - -
@sentry/svelte 29.84 kB - -
@sentry/remix (Remix 3 client bundle) 56.91 kB - -
CDN Bundle 31.55 kB - -
CDN Bundle (incl. Tracing) 52.41 kB - -
CDN Bundle (incl. Logs, Metrics) 33.75 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 54.34 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 74.67 kB - -
CDN Bundle (incl. Tracing, Replay) 90.06 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 92 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 96.23 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 98.18 kB - -
CDN Bundle - uncompressed 92.91 kB - -
CDN Bundle (incl. Tracing) - uncompressed 155.53 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 99.45 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 161.48 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 229.48 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 275.7 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 281.63 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 289.4 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 295.33 kB - -
@sentry/nextjs (client) 56.59 kB - -
@sentry/sveltekit (client) 52.27 kB - -
@sentry/core/server 40.91 kB +0.08% +31 B 🔺
@sentry/core/browser 13.74 kB - -
@sentry/node 151.76 kB +0.03% +37 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 83.77 kB - -
@sentry/node - without tracing 94.32 kB +0.05% +45 B 🔺
@sentry/node - without channel injection 129.94 kB +0.04% +47 B 🔺
@sentry/aws-serverless 102.48 kB +0.05% +43 B 🔺
@sentry/cloudflare (withSentry) - minified 210.2 kB - -
@sentry/cloudflare (withSentry) 521.15 kB - -
@sentry/nextjs/cloudflare (withSentry) - minified 227.88 kB - -

View base workflow run

@andreiborza
andreiborza marked this pull request as ready for review October 12, 2026 09:39
@andreiborza
andreiborza marked this pull request as ready for review October 12, 2026 09:39
@andreiborza
andreiborza merged commit b5a707d into develop Oct 12, 2026
706 of 708 checks passed
@andreiborza
andreiborza deleted the ab/http-client-abort-not-error branch October 12, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants