Repository navigation
fix(core): Don't mark http client spans as errors when the caller aborts - #25260
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
andreiborza
marked this pull request as ready for review
October 12, 2026 09:39
andreiborza
marked this pull request as ready for review
October 12, 2026 09:39
JPeer264
approved these changes
Oct 12, 2026
Lms24
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Outgoing
node:httpspans no longer get an error status when the caller aborts the request (for example withAbortController.abort()). If a response already arrived, the span keeps the status of that response.Why
A caller abort is not a request failure, and it showed false
http.clienterrors (for example for axios cancellation). This matches the fetch fix in #25129.