fix(wasm): Match Firefox call-site-derived wasm frames to the single buffer module - #23662
Draft
andreiborza wants to merge 1 commit into
Draft
fix(wasm): Match Firefox call-site-derived wasm frames to the single buffer module#23662andreiborza wants to merge 1 commit into
andreiborza wants to merge 1 commit into
Conversation
…buffer module Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Firefox names buffer-compiled modules after the compile call site (
app.js line 12 > WebAssembly.instantiate), which cannot be predicted at registration time. Such frames now resolve to the registered buffer module when exactly one distinct module exists. Unmatchedwasm://names stay unmatched, since those come from modules compiled before the SDK started.Why
Without this, non-streaming symbolication works everywhere except Firefox.
Related: #19564