perf(hono): Skip throwing request event probe - #23612
Closed
scttcper wants to merge 2 commits into
Closed
Conversation
Hono's event getter throws for ordinary requests, allocating an Error each time request metadata is initialized. The raw request is already the same original Request in every supported runtime, including legacy FetchEvent contexts. Use req.raw directly and remove the compatibility probe. Co-Authored-By: OpenAI Codex <codex@openai.com>
Contributor
size-limit report 📦
|
Fold the raw request assertion into the existing request handler test. Keep one focused regression test for the legacy FetchEvent compatibility path. Co-Authored-By: OpenAI Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
context.eventthrows in most Hono runtimes, so checking it creates and catches an Error on every request. The check was added with Cloudflare support in #18787 to cover both module workers and old-style service workers.We do not need two paths. Hono creates
context.req.rawfrom the same Request asevent.request, including in old-style Cloudflare workers. We verified this in Hono 4.0.0, the 4.11.7 version used by #18787, the current 4.13.4, and a regression test.Using
context.req.rawdirectly preserves the behavior and saves roughly 2 microseconds per request in the local benchmark.