test(node-integration-tests): Unflake LocalVariables out-of-app capture - #23608
Closed
RulaKhaled wants to merge 1 commit into
Closed
test(node-integration-tests): Unflake LocalVariables out-of-app capture#23608RulaKhaled wants to merge 1 commit into
RulaKhaled wants to merge 1 commit into
Conversation
…s out-of-app assertions These scenarios threw after a fixed 500ms, which can beat the debugger worker on loaded CI and drop vars from the event. Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
Collaborator
Author
|
Closing: this is not currently failing on |
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Node 20.19 integration job on #23573 failed with
expected undefined to deeply equal { inAppVar: 'in app value' }inadds local variables to out of app frames when includeOutOfAppFrames is true. That PR does not touch LocalVariables, and the same suite passed on Node 22, 24, and 26 in the same run.Root cause: LocalVariables captures vars on a worker that attaches after
inspector.open(). The out-of-app scenarios threw after a fixed 500ms, which is short enough on a loaded runner for the throw to land before pause-on-exceptions is enabled — so the event is sent withoutvars. Other tests in this suite already wait 1000ms; these two did not.Decision: wait until
inspector.url()is actually set, then give the worker a beat to enable the debugger, instead of lengthening another blind timeout. Frame lookup also acceptsObject.<name>, which this suite already treats as a valid Node function-name variant.Unrelated to #23573.