feat(core)!: Emit low cardinality supabase db span names - #23606
Draft
Lms24 wants to merge 1 commit into
Draft
Conversation
With span streaming, supabase query spans are named
`{db.operation.name} {db.collection.name}` (`update users`) instead of the
PostgREST description. The description embeds the translated filter list, which
carries user values (`eq(email, secret@example.com)`), so it cannot be a span
name. The filters stay on the `db.query` attribute, subject to the existing data
collection settings.
`auth` spans are unaffected: they have no collection to pair the operation with,
so the templates would reduce them to `postgresql`, which says less than the
name they already carry.
`traceLifecycle: 'static'` keeps the existing names.
Refs #23523
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With span streaming enabled:
{db.operation.name} {db.collection.name}update(...) eq(email, a@b.com) from(users)becomesupdate usersdb.queryattribute, as beforeauthspans unchanged; templates would reduce them topostgresqltraceLifecycle: 'static'keeps the existing namesRefs #23523