feat(server-utils)!: Emit low cardinality knex, tedious and prisma db span names - #23602
Draft
Lms24 wants to merge 1 commit into
Draft
feat(server-utils)!: Emit low cardinality knex, tedious and prisma db span names#23602Lms24 wants to merge 1 commit into
Lms24 wants to merge 1 commit into
Conversation
… span names
With span streaming, these three name their query spans from the span name
conventions instead of the SQL statement. They are grouped because each needs a
different fallback: knex drops to its existing `{operation} {namespace}.{table}`,
tedious has no statement to summarize and keeps `getSpanName`, and prisma resolves
its statement from either `db.statement` or `db.query.text` depending on version.
knex and prisma also report the new `db.query.summary` attribute.
`traceLifecycle: 'static'` keeps the existing names.
Refs #23523
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c57ede4. Configure here.
| // `from`/`join` can't leak a value into the summary. | ||
| const querySummary = dbStatement | ||
| ? _INTERNAL_getSqlQuerySummary(_INTERNAL_sanitizeSqlQuery(dbStatement)) | ||
| : undefined; |
There was a problem hiding this comment.
Truncation breaks summary sanitization
Medium Severity
Knex truncates the SQL with truncate before _INTERNAL_sanitizeSqlQuery and _INTERNAL_getSqlQuerySummary. Truncation can cut an open string literal, so the sanitize pass misses it and FROM/JOIN tokens inside that literal can land in db.query.summary and the streamed span name, which is the leak this sanitization step is meant to block.
Reviewed by Cursor Bugbot for commit c57ede4. Configure here.
|
|
||
| return startInactiveSpan({ | ||
| name: dbStatement ?? getName(name, operation, table) ?? 'knex.query', | ||
| name: streamedName ?? dbStatement ?? getName(name, operation, table) ?? 'knex.query', |
There was a problem hiding this comment.
Feat PR missing integration tests
Medium Severity
Flagged because the PR review guidelines ask feat PRs to include at least one integration or E2E test. This change adds streamed low-cardinality names and db.query.summary for knex, prisma, and tedious, but the commit has no tests that assert the new naming or attributes under traceLifecycle: 'stream' versus static.
Additional Locations (2)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit c57ede4. Configure here.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With span streaming enabled:
db.query.summary{operation} {namespace}.{table}{operation} {namespace}db.query.summaryattribute on knex and prismatraceLifecycle: 'static'keeps the existing namesGrouped because each needs a different per-driver fallback.
Refs #23523