feat(core): Emit low-cardinality http.server span names when streaming - #23596
Draft
chargome wants to merge 1 commit into
Draft
feat(core): Emit low-cardinality http.server span names when streaming#23596chargome wants to merge 1 commit into
chargome wants to merge 1 commit into
Conversation
With span streaming enabled, an http.server span is named after the request method rather than
the URL path when no route is resolved. Routed requests keep `${method} ${route}`, and `static`
mode is unchanged.
The scope's transaction name keeps the full path, so error grouping is unaffected. Two test suites
matched spans by name and now match on `url.path`, which is what is available at span start.
Refs #23527
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 75d96fd. Configure here.
| // Route instrumentations rename the span to `${method} ${route}` once a route is known. | ||
| const name = hasSpanStreamingEnabled(client) | ||
| ? request.method?.toUpperCase() || HTTP_SPAN_NAME_FALLBACK | ||
| : `${method} ${httpTargetWithoutQueryFragment}`; |
There was a problem hiding this comment.
Routed spans keep method-only names
High Severity
With streaming enabled, http.server spans start named only after the request method, assuming route instrumentations later rename them to METHOD /route. Native Express and similar integrations only call setTransactionName on the isolation scope and never update the span, so routed requests keep a method-only name.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 75d96fd. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Names
http.serverspans after the request method instead of the URL path when span streaming is enabled and no route resolved. Routed requests are unchanged,staticmode is byte-identical, and the scope's transaction name keeps the full path so error grouping is unaffected.Refs #23527