feat(core): Emit low cardinality mcp notification span names - #23586
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
andreiborza
marked this pull request as ready for review
August 25, 2026 13:51
Contributor
size-limit report 📦
|
chargome
approved these changes
Aug 25, 2026
Member
There was a problem hiding this comment.
Should be in the end state file
Member
Author
There was a problem hiding this comment.
I also moved the already landed pageload/graphql stuff.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
andreiborza
force-pushed
the
ab/mcp-notification-span-names
branch
from
August 26, 2026 07:32
3485246 to
7f02e2f
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7f02e2f. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
MCP notification spans now fall back to
MCP notificationwhen the message carries no method name and span streaming is enabled. Notifications with a method name keep it, and static mode is unchanged.Why
Span names must be low cardinality when span streaming is enabled. The notification method name already matches the convention, so only the missing-method case needed the static fallback.
Closes: #23530