fix(nextjs): Remove orchestrion webpack plugin lazy loading#22184
Closed
timfish wants to merge 4 commits into
Closed
fix(nextjs): Remove orchestrion webpack plugin lazy loading#22184timfish wants to merge 4 commits into
timfish wants to merge 4 commits into
Conversation
timfish
force-pushed
the
timfish/test/tbp
branch
from
0de1061 to
08b4219
Compare
timfish
changed the title
timfish
requested review from
JPeer264,
chargome,
isaacs,
mydea and
nicohrubec
and removed request for
a team
timfish
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 08b4219. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
isaacs
reviewed
Jul 10, 2026
isaacs
left a comment
isaacs
left a comment
Member
There was a problem hiding this comment.
This is an obvious improvement once we drop support for node <20.19, but landing this ahead of updating the engines field seems like a mistake. Can we mark it as targetting v11 and let it wait until then?
Collaborator
Author
|
Agreed, I think this might be a better option: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the orchestrion feature is tergetting v11, our minimum supported Node version will be v20.19 and therefore all supported versions will support
require(esm). For that reason I've changed the default export to be ESM. This works around the ESM interop issues and we no longer need to load the library lazily.