feat(nestjs): add orchestrion diagnostics-channel instrumentation#22176
Open
isaacs wants to merge 1 commit into
Open
feat(nestjs): add orchestrion diagnostics-channel instrumentation#22176isaacs wants to merge 1 commit into
isaacs wants to merge 1 commit into
Conversation
isaacs
requested review from
JPeer264,
andreiborza,
chargome,
mydea and
s1gr1d
and removed request for
a team
isaacs
force-pushed
the
isaacs/nestjs-orchestrion-impl
branch
from
2ace4ec to
d7b514a
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d7b514a. Configure here.
Contributor
size-limit report 📦
|
isaacs
force-pushed
the
isaacs/nestjs-extract-helpers
branch
from
1eb7633 to
fa0de85
Compare
isaacs
force-pushed
the
isaacs/nestjs-orchestrion-impl
branch
from
d7b514a to
9d8bcb6
Compare
isaacs
force-pushed
the
isaacs/nestjs-extract-helpers
branch
from
fa0de85 to
dd92103
Compare
isaacs
force-pushed
the
isaacs/nestjs-orchestrion-impl
branch
from
9d8bcb6 to
f3a502e
Compare
isaacs
force-pushed
the
isaacs/nestjs-extract-helpers
branch
from
dd92103 to
b74dcbd
Compare
isaacs
force-pushed
the
isaacs/nestjs-orchestrion-impl
branch
from
f3a502e to
d63141c
Compare
isaacs
force-pushed
the
isaacs/nestjs-extract-helpers
branch
from
b74dcbd to
9315716
Compare
isaacs
force-pushed
the
isaacs/nestjs-orchestrion-impl
branch
from
d63141c to
9e50193
Compare
Add the NestJS channel subscriber in `@sentry/nestjs`, plus its code-transform config and channel names in `@sentry/server-utils`. `nestIntegration` now uses the diagnostics-channel path when orchestrion is injected and the vendored OTel path otherwise. Only the span origin differs between the two implementations. Fix: JS-2519 Fix: #20947
isaacs
force-pushed
the
isaacs/nestjs-extract-helpers
branch
from
9315716 to
28b5141
Compare
isaacs
force-pushed
the
isaacs/nestjs-orchestrion-impl
branch
from
9e50193 to
74f223d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the NestJS channel subscriber in
@sentry/nestjs, plus its code-transform config and channel names in@sentry/server-utils.nestIntegrationnow uses the diagnostics-channel path when orchestrion is injected and the vendored OTel path otherwise. Only the span origin differs between the two implementations.Fix: JS-2519
Fix: #20947