ref(nestjs): extract shared span helpers#22175
Open
isaacs wants to merge 1 commit into
Open
Conversation
isaacs
requested review from
chargome,
mydea and
nicohrubec
and removed request for
a team
Contributor
size-limit report 📦
|
nicohrubec
approved these changes
Jul 10, 2026
nicohrubec
left a comment
nicohrubec
left a comment
Member
There was a problem hiding this comment.
overall lgtm, I just have two small questions/remarks
isaacs
force-pushed
the
isaacs/node-move-default-integration-swap
branch
from
7b12bae to
63a580f
Compare
isaacs
requested review from
JPeer264 and
andreiborza
and removed request for
a team
isaacs
force-pushed
the
isaacs/nestjs-extract-helpers
branch
from
1eb7633 to
fa0de85
Compare
isaacs
force-pushed
the
isaacs/node-move-default-integration-swap
branch
from
63a580f to
89c3b4c
Compare
isaacs
force-pushed
the
isaacs/nestjs-extract-helpers
branch
from
fa0de85 to
dd92103
Compare
isaacs
force-pushed
the
isaacs/node-move-default-integration-swap
branch
from
89c3b4c to
1d877df
Compare
isaacs
force-pushed
the
isaacs/nestjs-extract-helpers
branch
from
dd92103 to
b74dcbd
Compare
isaacs
force-pushed
the
isaacs/node-move-default-integration-swap
branch
from
1d877df to
5d4d988
Compare
isaacs
force-pushed
the
isaacs/nestjs-extract-helpers
branch
from
b74dcbd to
9315716
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Pull the span-emitting/patching logic out of the OTel `InstrumentationBase` classes into `wrap-components`, `wrap-handlers`, and `wrap-route` so it can be reused by the diagnostics-channel integration. Refactor only. There is still only the OTel implementation, which still emits the same spans as before. However, this will be needed when the next implementation is added.
isaacs
force-pushed
the
isaacs/node-move-default-integration-swap
branch
from
5d4d988 to
b2a369d
Compare
isaacs
force-pushed
the
isaacs/nestjs-extract-helpers
branch
from
9315716 to
28b5141
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull the span-emitting/patching logic out of the OTel
InstrumentationBaseclasses intowrap-components,wrap-handlers, andwrap-routeso it can be reused by the diagnostics-channel integration.Refactor only. There is still only the OTel implementation, which still emits the same spans as before. However, this will be needed when the next implementation is added.