feat(node): move dc integration swap to _init#22173
Open
isaacs wants to merge 1 commit into
Open
Conversation
isaacs
requested review from
JPeer264,
andreiborza and
mydea
and removed request for
a team
Contributor
size-limit report 📦
|
isaacs
force-pushed
the
isaacs/update-apm-js
branch
from
8614323 to
007021e
Compare
isaacs
force-pushed
the
isaacs/node-move-default-integration-swap
branch
from
7b12bae to
63a580f
Compare
isaacs
force-pushed
the
isaacs/update-apm-js
branch
from
007021e to
6e9eab7
Compare
isaacs
force-pushed
the
isaacs/node-move-default-integration-swap
branch
from
63a580f to
89c3b4c
Compare
isaacs
force-pushed
the
isaacs/update-apm-js
branch
from
6e9eab7 to
83b3106
Compare
isaacs
force-pushed
the
isaacs/node-move-default-integration-swap
branch
from
89c3b4c to
1d877df
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
isaacs
force-pushed
the
isaacs/node-move-default-integration-swap
branch
from
1d877df to
5d4d988
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5d4d988. Configure here.
Move the diagnostics-channel integration swap out of `getDefaultIntegrations` and into `_init`, so it also applies to framework SDKs that pass their own `defaultIntegrations` array, and is skipped when defaults are explicitly empty. This will be needed because the NestJS SDK (and others) build on top of the Node SDK, but swap out their default integrations.
isaacs
force-pushed
the
isaacs/node-move-default-integration-swap
branch
from
5d4d988 to
b2a369d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the diagnostics-channel integration swap out of
getDefaultIntegrationsand into_init, so it also applies to framework SDKs that pass their owndefaultIntegrationsarray, and is skipped when defaults are explicitly empty.This will be needed because the NestJS SDK (and others) build on top of the Node SDK, but swap out their default integrations.