test(nitro-3): Update e2e tests for h3 route handler tracing#21152
Open
logaretm wants to merge 1 commit into
Open
test(nitro-3): Update e2e tests for h3 route handler tracing#21152logaretm wants to merge 1 commit into
logaretm wants to merge 1 commit into
Conversation
logaretm
force-pushed
the
feat/nitro-3-h3-route-handler-spans
branch
from
bda3cd6 to
098e446
Compare
logaretm
requested review from
a team,
mydea and
s1gr1d
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nitro
3.0.260522-beta(nitrojs/nitro#4240) now wraps file-based route handlers withwrapHandlerWithTracingfromh3/tracingat build time. This means h3 emits route handler spans viadiagnostics_channel, fixing the missing route spans we had workarounds for.so this PR bumps nitro test app from
^3.0.260429-betato^3.0.260522-beta, and asserts thatstartSpanassertions and db spans are now children of the h3 route handler span, not the srvx span directly.Also errors thrown in route handlers are now caught by the h3 tracing channel (
auto.http.nitro.onTraceError) instead of going through Nitro's error hook (captureErrorHook), and are no longer wrapped in anHTTPErrorsince those happen on the handler level now.