Skip to content

feat(tanstackstart-react): Filter noisy dev transactions #21145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nicohrubec wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

feat(tanstackstart-react): Filter noisy dev transactions #21145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6acd484
feat(tanstackstart-react): Filter noisy dev transactions via ignoreSpans
nicohrubec May 23, 2026
227d655
fix: Add ignoreSpans to client init, drop GET prefix from patterns
nicohrubec May 23, 2026
b806f8e
fix: Add /@fs/ and /@vite/ to ignoreSpans
nicohrubec May 23, 2026
d5c230b
fix: Trim server ignoreSpans to only patterns that produce transactions
nicohrubec May 23, 2026
115e55f
fix: Fix server sdk test to assert a pattern that actually exists
nicohrubec May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/tanstackstart-react/src/client/sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,16 @@ export function init(options: ReactBrowserOptions): Client | undefined {
applyTunnelRouteOption(sentryOptions);
applySdkMetadata(sentryOptions, 'tanstackstart-react', ['tanstackstart-react', 'react']);

sentryOptions.ignoreSpans = [
...(sentryOptions.ignoreSpans || []),
/\/node_modules\//,
/\/favicon\.ico/,
/\/@id\//,
/\/@react-refresh/,
/\/@tanstack-start\//,
/\/@fs\//,
Comment thread
nicohrubec marked this conversation as resolved.
/\/@vite\//,
];
Comment thread
nicohrubec marked this conversation as resolved.

return initReactSDK(sentryOptions);
}
8 changes: 8 additions & 0 deletions packages/tanstackstart-react/src/server/sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,13 @@ export function init(options: NodeOptions): NodeClient | undefined {

applySdkMetadata(sentryOptions, 'tanstackstart-react', ['tanstackstart-react', 'node']);

sentryOptions.ignoreSpans = [
...(sentryOptions.ignoreSpans || []),
/\/node_modules\//,
/\/@id\//,
/\/@react-refresh/,
/\/@vite\//,
];
Comment thread
nicohrubec marked this conversation as resolved.

return initNodeSdk(sentryOptions);
}
31 changes: 31 additions & 0 deletions packages/tanstackstart-react/test/client/sdk.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,37 @@ describe('TanStack Start React Client SDK', () => {
expect(init({})).not.toBeUndefined();
});

it('sets ignoreSpans to filter low-quality spans', () => {
init({ dsn: 'https://public@dsn.ingest.sentry.io/1337' });

expect(reactInit).toHaveBeenCalledWith(
expect.objectContaining({
ignoreSpans: expect.arrayContaining([
/\/node_modules\//,
/\/favicon\.ico/,
/\/@id\//,
/\/@react-refresh/,
/\/@tanstack-start\//,
/\/@fs\//,
/\/@vite\//,
]),
}),
);
});

it('preserves user-defined ignoreSpans', () => {
init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
ignoreSpans: [/custom-pattern/],
});

expect(reactInit).toHaveBeenCalledWith(
expect.objectContaining({
ignoreSpans: expect.arrayContaining([/custom-pattern/, /\/favicon\.ico/]),
}),
);
});

it('applies the managed tunnel route when no runtime tunnel is provided', () => {
vi.stubGlobal('__SENTRY_TANSTACKSTART_TUNNEL_ROUTE__', '/managed-tunnel');

Expand Down
23 changes: 23 additions & 0 deletions packages/tanstackstart-react/test/server/sdk.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,28 @@ describe('TanStack Start React Server SDK', () => {
it('returns client from init', () => {
expect(init({})).not.toBeUndefined();
});

it('sets ignoreSpans to filter low-quality transactions', () => {
init({ dsn: 'https://public@dsn.ingest.sentry.io/1337' });

expect(nodeInit).toHaveBeenCalledWith(
expect.objectContaining({
ignoreSpans: expect.arrayContaining([/\/node_modules\//, /\/@id\//, /\/@react-refresh/, /\/@vite\//]),
}),
);
});

it('preserves user-defined ignoreSpans', () => {
init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
ignoreSpans: [/custom-pattern/],
});

expect(nodeInit).toHaveBeenCalledWith(
expect.objectContaining({
ignoreSpans: expect.arrayContaining([/custom-pattern/, /\/@vite\//]),
}),
);
});
Comment thread
nicohrubec marked this conversation as resolved.
Comment thread
nicohrubec marked this conversation as resolved.
});
});
Loading