fix(core): Fix withStreamedSpan typing error add missing exports#20124
Open
Lms24 wants to merge 3 commits intolms/feat-span-firstfrom
Open
fix(core): Fix withStreamedSpan typing error add missing exports#20124Lms24 wants to merge 3 commits intolms/feat-span-firstfrom
withStreamedSpan typing error add missing exports#20124Lms24 wants to merge 3 commits intolms/feat-span-firstfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Core
Deps
Other
Bug Fixes 🐛Core
Other
Internal Changes 🔧Core
Deps
Other
🤖 This preview updates automatically when you update the PR. |
Lms24
changed the title
withStreamedSpan typing error and export from SDKswithStreamedSpan typing error add missing exports
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 44ea531. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
mydea
reviewed
Apr 8, 2026
| callback: ClientOptions['beforeSendSpan'], | ||
| ): callback is BeforeSendStramedSpanCallback { | ||
| return !!callback && '_streamed' in callback && !!callback._streamed; | ||
| callback: (ClientOptions['beforeSendSpan'] & { _streamed?: true }) | unknown, |
Member
There was a problem hiding this comment.
l: is this not equivalent to callback: unknown? 🤔
mydea
approved these changes
Apr 8, 2026
Member
mydea
left a comment
mydea
left a comment
There was a problem hiding this comment.
left a tiny note but looks good to me!
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Lms24
force-pushed
the
lms/feat-span-streaming-exports
branch
from
d561aa5 to
53f5d9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes some changes to the span streaming
beforeSendSpanimplementation:Previously
beforeSendSpanwas typed via discriminated union. While I initially thought this would work, it would break type checking for user-provided staticbeforeSendSpancallbacks because TS couldn't infer if the callback received aSpanJSONor aStreamedSpanJSON. So it defaulted tounknown. Now, we "pretend" that everybeforeSendSpancallback receives and returns aSpanJSON. Since we instruct users for span streaming to use thewithStreamedSpanhelper anyway, they will get correct typing within the wrapper function (i.e. a callback receiving and returningStreamedSpanJSON.Other changes:
withStreamedSpanhelper from every SDKwarntologthat the browserspanStreamingIntegrationautomatically setstraceLifecycle: 'stream'. This is expected behaviour and we'll instruct users to only setspanStreamingIntegrationto avoid a double-opt-in situation.