feat(v11): Drop TypeScript 3.8 support#18604
Draft
logaretm wants to merge 1 commit into
Draft
Conversation
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
424934f to
dea5658
Compare
bf9dfc3 to
f8824a4
Compare
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you apply the label |
0ccb9a1 to
fb2b2d8
Compare
410a72f to
bc07973
Compare
bc07973 to
21ebf07
Compare
Contributor
size-limit report 📦
|
Minimum supported TypeScript is now 5.0, so remove the downlevel-dts type path and the TS 3.8 test surface: - drop each package's typesVersions "<5.0" mapping and the build:types:downlevel step (build:types is just tsc now) - remove downlevel-dts and the ts3.8 shim scripts/type-shims - bump the node integration-test TS matrix to 5.0 (use-ts-5_0) - drop the TS 3.8 e2e variants and the generic-ts3.8 app - use the built-in Awaited type instead of the vendored shim
b48cbc7 to
18271b3
Compare
21ebf07 to
e2e63ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes support for generating and publishing TypeScript 3.8 downleveled type definitions across all packages.
The changes simplify the build process by eliminating scripts, dependencies, and configuration related to downleveling types, and update test and project configuration accordingly.
closes #18477
TODO:
package.json