fix(bun) Export pinoIntegration from @sentry/node#17990
fix(bun) Export pinoIntegration from @sentry/node#17990LudvigHz wants to merge 2 commits intogetsentry:developfrom
Conversation
|
@timfish not sure if the pino integration works properly on bun due to |
|
I think Bun supports What won't work is the code injection via ESM loader hook because Bun doesn't support them. If loader hook registration is simply a no-op in Bun, it might just work with the latest versions of Pino without causing runtime errors? @LudvigHz have you tested this working with Bun? |
|
Bun supports the tracing channel, but they do not publish to the channels we use for the instrumentation. More about that here: #17779 (comment) |
|
Follow-up on the above comment: Bun has a PR for supporting the channels oven-sh/bun#24375 |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you apply the label |
|
I think this can probably be merged! The Pino integration will work with Bun for any Pino version that publishes tracing channel events (I forget the exact version!) |
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).Resolves #17989