Skip to content

node-integration-tests: drop static pins from non-tracing suites #24141

Closed

Description

@andreiborza

Follow the porting recipe in the parent issue.

Largest group by file count and the smallest by effort. Roughly 90 suite directories carry the traceLifecycle: 'static' pin without ever asserting on a transaction envelope, so the pin just needs to go.

Suites (pin removal only)

  • public-api/* except the span surface dirs owned by the trace semantics sub-issue: addBreadcrumb, captureException, captureMessage, configureScope, LocalVariables, logger, metrics, OnUncaughtException, setContext, setExtra, setExtras, setTag, setTags, setUser, withMonitor, withScope
  • sessions, cron/*, client-reports/periodic-send
  • Logging: pino, winston, consola, integrations/console/filter
  • Runtime: anr, system-error, thread-blocked-native, child-process, modules, esm/*, contextLines/*, breadcrumbs/process-thread, node-runtime-metrics, bun-runtime-metrics
  • vercel/sigterm-flush

Suites that still need an assertion rewrite

These 7 do assert on transaction envelopes:

  • public-api/onUnhandledRejectionIntegration
  • client-reports/drop-reasons/* (4 dirs)
  • featureFlags/featureFlagsIntegration/onSpan and featureFlags/growthbook/onSpan
  • fs-instrumentation
  • aws-serverless/aws-integration (fold aws-serverless/aws-integration-streamed back into it)

Splitting this issue into a mechanical pin-removal PR and a smaller rewrite PR is fine.

Activity

  1. linear-code commented on Sep 7, 2026

    @linear-code
  2. self-assigned this
    on Oct 3, 2026
  3. added a commit that references this issue on Oct 6, 2026
    b139c53
  4. github-actions commented on Oct 7, 2026

    @github-actions
    Contributor

    A PR closing this issue has just been released 🚀

    This issue was referenced by PR #25019, which was included in the 11.5.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

TaskjavascriptPull requests that update javascript code

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions